Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 261823008: Reorganize barback's source files. (Closed)

Created:
6 years, 7 months ago by nweiz
Modified:
6 years, 7 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reorganize barback's source files. This creates four directories beneath barback/lib/src: * asset/ contains the Asset and AssetNode classes, as well as various classes for dealing with them. * graph/ contains the classes that make up the barback asset graph, as well as utility classes that are specific to these (such as NodeStreams). * transformer/ contains Transformer and similar classes (such as TransformerGroup), as well as the classes (such as Transform) that are passed to Transformer methods. * utils/ contains utility classes that aren't barback-specific (such as CancelableFuture). R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=35777

Patch Set 1 #

Patch Set 2 : re-add barback/lib/src/internal_asset.dart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -3926 lines) Patch
M pkg/barback/lib/barback.dart View 1 chunk +13 lines, -12 lines 0 comments Download
D pkg/barback/lib/src/asset.dart View 1 chunk +0 lines, -50 lines 0 comments Download
A + pkg/barback/lib/src/asset/asset.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/barback/lib/src/asset/asset_forwarder.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/barback/lib/src/asset/asset_id.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/barback/lib/src/asset/asset_node.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + pkg/barback/lib/src/asset/asset_node_set.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/barback/lib/src/asset/asset_set.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/barback/lib/src/asset/internal_asset.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download
D pkg/barback/lib/src/asset_cascade.dart View 1 chunk +0 lines, -222 lines 0 comments Download
D pkg/barback/lib/src/asset_forwarder.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D pkg/barback/lib/src/asset_id.dart View 1 chunk +0 lines, -111 lines 0 comments Download
D pkg/barback/lib/src/asset_node.dart View 1 chunk +0 lines, -283 lines 0 comments Download
D pkg/barback/lib/src/asset_node_set.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/barback/lib/src/asset_set.dart View 1 chunk +0 lines, -73 lines 0 comments Download
M pkg/barback/lib/src/barback.dart View 1 chunk +5 lines, -5 lines 0 comments Download
D pkg/barback/lib/src/barback_settings.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D pkg/barback/lib/src/base_transform.dart View 1 chunk +0 lines, -94 lines 0 comments Download
D pkg/barback/lib/src/cancelable_future.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D pkg/barback/lib/src/declaring_transform.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D pkg/barback/lib/src/declaring_transformer.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M pkg/barback/lib/src/errors.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D pkg/barback/lib/src/file_pool.dart View 1 chunk +0 lines, -66 lines 0 comments Download
A + pkg/barback/lib/src/graph/asset_cascade.dart View 1 chunk +9 lines, -9 lines 0 comments Download
A + pkg/barback/lib/src/graph/group_runner.dart View 1 chunk +5 lines, -5 lines 0 comments Download
A + pkg/barback/lib/src/graph/node_status.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/barback/lib/src/graph/node_streams.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + pkg/barback/lib/src/graph/package_graph.dart View 1 chunk +10 lines, -10 lines 0 comments Download
A + pkg/barback/lib/src/graph/phase.dart View 1 chunk +10 lines, -10 lines 0 comments Download
A + pkg/barback/lib/src/graph/phase_forwarder.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/barback/lib/src/graph/phase_output.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + pkg/barback/lib/src/graph/transform_node.dart View 1 chunk +12 lines, -12 lines 0 comments Download
A + pkg/barback/lib/src/graph/transformer_classifier.dart View 1 chunk +7 lines, -7 lines 0 comments Download
D pkg/barback/lib/src/group_runner.dart View 1 chunk +0 lines, -95 lines 0 comments Download
D pkg/barback/lib/src/internal_asset.dart View 1 1 chunk +10 lines, -182 lines 0 comments Download
D pkg/barback/lib/src/lazy_transformer.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/barback/lib/src/log.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/barback/lib/src/multiset.dart View 1 chunk +0 lines, -63 lines 0 comments Download
D pkg/barback/lib/src/node_status.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D pkg/barback/lib/src/node_streams.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D pkg/barback/lib/src/package_graph.dart View 1 chunk +0 lines, -264 lines 0 comments Download
M pkg/barback/lib/src/package_provider.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D pkg/barback/lib/src/phase.dart View 1 chunk +0 lines, -384 lines 0 comments Download
D pkg/barback/lib/src/phase_forwarder.dart View 1 chunk +0 lines, -134 lines 0 comments Download
D pkg/barback/lib/src/phase_output.dart View 1 chunk +0 lines, -114 lines 0 comments Download
D pkg/barback/lib/src/pool.dart View 1 chunk +0 lines, -141 lines 0 comments Download
M pkg/barback/lib/src/serialize.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/barback/lib/src/stream_pool.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D pkg/barback/lib/src/stream_replayer.dart View 1 chunk +0 lines, -83 lines 0 comments Download
D pkg/barback/lib/src/transform.dart View 1 chunk +0 lines, -119 lines 0 comments Download
D pkg/barback/lib/src/transform_logger.dart View 1 chunk +0 lines, -71 lines 0 comments Download
D pkg/barback/lib/src/transform_node.dart View 1 chunk +0 lines, -535 lines 0 comments Download
D pkg/barback/lib/src/transformer.dart View 1 chunk +0 lines, -93 lines 0 comments Download
A + pkg/barback/lib/src/transformer/barback_settings.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/barback/lib/src/transformer/base_transform.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/barback/lib/src/transformer/declaring_transform.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/barback/lib/src/transformer/declaring_transformer.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/barback/lib/src/transformer/lazy_transformer.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/barback/lib/src/transformer/transform.dart View 1 chunk +7 lines, -7 lines 0 comments Download
A + pkg/barback/lib/src/transformer/transform_logger.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/barback/lib/src/transformer/transformer.dart View 1 chunk +3 lines, -3 lines 0 comments Download
A + pkg/barback/lib/src/transformer/transformer_group.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/barback/lib/src/transformer_classifier.dart View 1 chunk +0 lines, -127 lines 0 comments Download
D pkg/barback/lib/src/transformer_group.dart View 1 chunk +0 lines, -30 lines 0 comments Download
A + pkg/barback/lib/src/utils/cancelable_future.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/barback/lib/src/utils/file_pool.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/barback/lib/src/utils/multiset.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/barback/lib/src/utils/pool.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/barback/lib/src/utils/stream_pool.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/barback/lib/src/utils/stream_replayer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/barback/test/asset_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/barback/test/cancelable_future_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/barback/test/multiset_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/barback/test/stream_pool_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/barback/test/stream_replayer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/barback/test/utils.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 7 months ago (2014-05-02 01:27:27 UTC) #1
Bob Nystrom
lgtm
6 years, 7 months ago (2014-05-02 16:46:02 UTC) #2
nweiz
PTAL Since pub used barback/lib/src/internal_asset.dart, I added a stub that exports the new location so ...
6 years, 7 months ago (2014-05-02 19:13:37 UTC) #3
Bob Nystrom
lgtm
6 years, 7 months ago (2014-05-05 20:37:22 UTC) #4
nweiz
6 years, 7 months ago (2014-05-05 22:59:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r35777 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698