Issue 261693002: Fix TryICData to create ICData with a valid arguments decriptor.

Issue 261693002: Fix TryICData to create ICData with a valid arguments decriptor. (Closed)

Created:
6 years, 7 months ago by srdjan

Modified:
6 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix TryICData to create ICData with a valid arguments decriptor. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35601

Patch Set 4 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -9 lines)			Patch
M	runtime/vm/flow_graph_compiler_arm.cc	View	1 2 3	3 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2	3 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 2 3	3 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3	3 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/261693002/diff/40001/runtime/vm/flow_graph_compiler_ia32.cc File runtime/vm/flow_graph_compiler_ia32.cc (right): https://codereview.chromium.org/261693002/diff/40001/runtime/vm/flow_graph_compiler_ia32.cc#newcode1243 runtime/vm/flow_graph_compiler_ia32.cc:1243: ASSERT(Array::Handle(ic_data.arguments_descriptor()).Length() > 0); You should add these asserts ...

6 years, 7 months ago (2014-04-30 21:47:06 UTC) #2

srdjan

https://codereview.chromium.org/261693002/diff/40001/runtime/vm/flow_graph_compiler_ia32.cc File runtime/vm/flow_graph_compiler_ia32.cc (right): https://codereview.chromium.org/261693002/diff/40001/runtime/vm/flow_graph_compiler_ia32.cc#newcode1243 runtime/vm/flow_graph_compiler_ia32.cc:1243: ASSERT(Array::Handle(ic_data.arguments_descriptor()).Length() > 0); On 2014/04/30 21:47:07, regis wrote: > ...

6 years, 7 months ago (2014-04-30 21:58:27 UTC) #3

srdjan

6 years, 7 months ago (2014-04-30 22:05:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r35601 (presubmit successful).

Expand Messages | Collapse Messages