runtime/vm/flow_graph_optimizer.cc - Issue 261693002: Fix TryICData to create ICData with a valid arguments decriptor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 261693002: Fix TryICData to create ICData with a valid arguments decriptor. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

===================================================================

--- runtime/vm/flow_graph_optimizer.cc (revision 35593)

+++ runtime/vm/flow_graph_optimizer.cc (working copy)

@@ -138,9 +138,9 @@

}

- ArgumentsDescriptor args_desc(

- Array::Handle(ArgumentsDescriptor::New(call->ArgumentCount(),

- call->argument_names())));

+ const Array& args_desc_array = Array::Handle(

+ ArgumentsDescriptor::New(call->ArgumentCount(), call->argument_names()));

+ ArgumentsDescriptor args_desc(args_desc_array);

const Class& receiver_class = Class::Handle(

Isolate::Current()->class_table()->At(class_ids[0]));

const Function& function = Function::Handle(

@@ -158,7 +158,7 @@

ICData& ic_data = ICData::ZoneHandle(ICData::New(

flow_graph_->parsed_function().function(),

call->function_name(),

- Object::empty_array(), // Dummy argument descriptor.

+ args_desc_array,

call->deopt_id(),

class_ids.length()));

if (class_ids.length() > 1) {

« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/il_printer.cc » ('j') | no next file with comments »