Use ShadowRoot to hide non-user content (for example, diagnostics).

Use ShadowRoot to hide non-user content (for example, diagnostics).

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35887

[ahe, 2014-05-06 15:49:27]

This will enable me to easily collect sources when I update a single line.

Right now, that's broken and complicated to fix. With these changes, it becomes
trivial:

  if (ShadowRoot.supported) return mainEditorPane.text;
  // Else use htmlToText to extract the text.

There are no new tests, as I think this is covered by existing tests. I'll add
tests to cover changing code when I make the change to collect sources.

[kasperl, 2014-05-06 16:58:29]

LGTM. I learned a few things reviewing this.

https://codereview.chromium.org/261413002/diff/40001/dart/site/try/src/intera...
File dart/site/try/src/interaction_manager.dart (right):

https://codereview.chromium.org/261413002/diff/40001/dart/site/try/src/intera...
dart/site/try/src/interaction_manager.dart:705:
getShadowRoot(ui).querySelectorAll(
Cache the shadowRoot in a local outside the loop?

[ahe, 2014-05-08 07:37:22]

Thank you, Kasper!

https://codereview.chromium.org/261413002/diff/40001/dart/site/try/src/intera...
File dart/site/try/src/interaction_manager.dart (right):

https://codereview.chromium.org/261413002/diff/40001/dart/site/try/src/intera...
dart/site/try/src/interaction_manager.dart:705:
getShadowRoot(ui).querySelectorAll(
On 2014/05/06 16:58:30, kasperl wrote:
> Cache the shadowRoot in a local outside the loop?

Done.

[ahe, 2014-05-08 07:49:32]

Committed patchset #2 manually as r35887 (presubmit successful).