dart/site/try/src/html_to_text.dart - Issue 261413002: Use ShadowRoot to hide non-user content (for example, diagnostics).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/site/try/src/html_to_text.dart

Issue 261413002: Use ShadowRoot to hide non-user content (for example, diagnostics). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address Kasper's comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/site/try/src/html_to_text.dart

diff --git a/dart/site/try/src/html_to_text.dart b/dart/site/try/src/html_to_text.dart

index f90ded6104c41d4aa137d3832a55173f7a01a0df..3b5dbb555ca793e04a8ca1a3729151fc0168ae07 100644

--- a/dart/site/try/src/html_to_text.dart

+++ b/dart/site/try/src/html_to_text.dart

@@ -11,6 +11,7 @@ import 'dart:html' show

Element,

Node,

NodeFilter,

+ ShadowRoot,

Text,

TreeWalker;

@@ -61,7 +62,11 @@ int htmlToText(Node root, StringBuffer buffer, TrySelection selection) {

break;

default:

- if (node.nodeName == 'BR') {

+ if (!ShadowRoot.supported &&

+ node is Element &&

+ node.getAttribute('try-dart-shadow-root') != null) {

+ skip(node, walker);

+ } else if (node.nodeName == 'BR') {

buffer.write('\n');

} else if (node != root && isBlockElement(node)) {

selectionOffset =

« no previous file with comments | « dart/site/try/src/editor.dart ('k') | dart/site/try/src/interaction_manager.dart » ('j') | no next file with comments »