Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26096002: New analyzer_experimental snapshot. (Closed)

Created:
7 years, 2 months ago by scheglov
Modified:
7 years, 2 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

New analyzer_experimental snapshot. 1. "catch (Exception e)" is translated into "on JavaException catch (e)". 2. Java exceptions now extend JavaException. 3. MemberMap moved into resolver, because it is not a generic collection and has references to elements. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=28296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1491 lines, -1111 lines) Patch
M editor/tools/plugins/com.google.dart.engine.services/src/com/google/dart/engine/services/internal/correction/QuickFixProcessorImpl.java View 2 chunks +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/InheritanceManager.java View 1 chunk +0 lines, -1 line 0 comments Download
A + editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/MemberMap.java View 3 chunks +11 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java View 3 chunks +2 lines, -2 lines 0 comments Download
D editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/utilities/collection/MemberMap.java View 1 chunk +0 lines, -174 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/InheritanceManagerTest.java View 1 chunk +0 lines, -1 line 0 comments Download
A + editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/MemberMapTest.java View 1 chunk +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/TestAll.java View 1 chunk +1 line, -0 lines 0 comments Download
D editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/utilities/collection/MemberMapTest.java View 1 chunk +0 lines, -75 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/utilities/collection/TestAll.java View 1 chunk +0 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 2 chunks +8 lines, -18 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/ast.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/constant.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/element.dart View 3 chunks +9 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/engine.dart View 33 chunks +410 lines, -190 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/error.dart View 66 chunks +133 lines, -147 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_core.dart View 2 chunks +8 lines, -18 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/parser.dart View 4 chunks +145 lines, -128 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/resolver.dart View 45 chunks +265 lines, -146 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/scanner.dart View 2 chunks +36 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/sdk_io.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source_io.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_experimental/test/generated/parser_test.dart View 4 chunks +41 lines, -0 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/resolver_test.dart View 42 chunks +264 lines, -114 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/scanner_test.dart View 7 chunks +39 lines, -2 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 3 chunks +92 lines, -56 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +1 line, -12 lines 0 comments Download
M tests/lib/analyzer/analyze_library.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 2 months ago (2013-10-05 01:24:09 UTC) #1
Brian Wilkerson
LGTM
7 years, 2 months ago (2013-10-05 15:06:58 UTC) #2
scheglov
7 years, 2 months ago (2013-10-06 05:11:34 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r28296 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698