editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java - Issue 26096002: New analyzer_experimental snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

Issue 26096002: New analyzer_experimental snapshot. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/MemberMap.java ('k') | editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/utilities/collection/MemberMap.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

index 89e16bf98a73ebaffe5888cfd66c63aad3840d8d..8fd44aec2f1b0bdc2881c5ea90b5d7c81ae40cbb 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java

@@ -125,6 +125,7 @@ import com.google.dart.engine.internal.element.member.ParameterMember;

import com.google.dart.engine.internal.error.ErrorReporter;

import com.google.dart.engine.internal.resolver.ElementResolver;

import com.google.dart.engine.internal.resolver.InheritanceManager;

+import com.google.dart.engine.internal.resolver.MemberMap;

import com.google.dart.engine.internal.resolver.TypeProvider;

import com.google.dart.engine.internal.scope.Namespace;

import com.google.dart.engine.internal.scope.NamespaceBuilder;

@@ -141,7 +142,6 @@ import com.google.dart.engine.type.FunctionType;

import com.google.dart.engine.type.InterfaceType;

import com.google.dart.engine.type.Type;

import com.google.dart.engine.type.TypeParameterType;

-import com.google.dart.engine.utilities.collection.MemberMap;

import com.google.dart.engine.utilities.dart.ParameterKind;

import com.google.dart.engine.utilities.general.ObjectUtilities;

@@ -1117,7 +1117,7 @@ public class ErrorVerifier extends RecursiveASTVisitor<Void> {

private boolean checkForAllInvalidOverrideErrorCodes(ExecutableElement executableElement,

ParameterElement[] parameters, ASTNode[] parameterLocations, SimpleIdentifier errorNameTarget) {

String executableElementName = executableElement.getName();

- boolean executableElementPrivate = SimpleIdentifier.isPrivateName(executableElementName);

+ boolean executableElementPrivate = Identifier.isPrivateName(executableElementName);

ExecutableElement overriddenExecutable = inheritanceManager.lookupInheritance(

enclosingClass,

executableElementName);