Issue 259903002: Enables all codegen tests for arm64.

Issue 259903002: Enables all codegen tests for arm64. (Closed)

Created:
6 years, 8 months ago by zra

Modified:
6 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Enables all codegen tests for arm64. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35448

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+541 lines, -21 lines)			Patch
M	runtime/vm/assembler_arm64.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View	1	3 chunks	+57 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator_test.cc	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View		1 chunk	+211 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View		2 chunks	+25 lines, -9 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View		3 chunks	+242 lines, -2 lines	0 comments	Download
M	runtime/vm/unit_test.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

CopyParameters and new stubs copied nearly verbatim from arm with small fix-ups.

6 years, 8 months ago (2014-04-25 21:02:43 UTC) #1

regis

LGTM https://codereview.chromium.org/259903002/diff/1/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/259903002/diff/1/runtime/vm/assembler_arm64.cc#newcode437 runtime/vm/assembler_arm64.cc:437: reg, reinterpret_cast<int64_t>(object.raw()), pp); one line https://codereview.chromium.org/259903002/diff/1/runtime/vm/intermediate_language_arm64.cc File runtime/vm/intermediate_language_arm64.cc ...

6 years, 8 months ago (2014-04-25 21:17:51 UTC) #2

zra

Thanks! https://codereview.chromium.org/259903002/diff/1/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/259903002/diff/1/runtime/vm/assembler_arm64.cc#newcode437 runtime/vm/assembler_arm64.cc:437: reg, reinterpret_cast<int64_t>(object.raw()), pp); On 2014/04/25 21:17:51, regis wrote: ...

6 years, 8 months ago (2014-04-25 21:28:28 UTC) #3

zra

6 years, 8 months ago (2014-04-25 21:28:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35448 (presubmit successful).

Expand Messages | Collapse Messages