Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 25940003: Issue 13510. Fix for parsing symbol literal with built-in identifiers. (Closed)

Created:
7 years, 2 months ago by scheglov
Modified:
7 years, 2 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java View 1 chunk +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/SimpleParserTest.java View 1 chunk +10 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 2 months ago (2013-10-03 21:28:50 UTC) #1
Brian Wilkerson
LGTM
7 years, 2 months ago (2013-10-03 21:52:49 UTC) #2
scheglov
7 years, 2 months ago (2013-10-03 22:17:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28247 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698