editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java - Issue 25940003: Issue 13510. Fix for parsing symbol literal with built-in identifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java

Issue 25940003: Issue 13510. Fix for parsing symbol literal with built-in identifiers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/SimpleParserTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java

index 6ee33f6284a63eee40e5bed23c0455a6f052dca2..3dd19f9550fa77a9e952e4b76d105438da98ddf1 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java

@@ -5019,11 +5019,11 @@ public class Parser {

private SymbolLiteral parseSymbolLiteral() {

Token poundSign = getAndAdvance();

List<Token> components = new ArrayList<Token>();

- if (matches(TokenType.IDENTIFIER)) {

+ if (matchesIdentifier()) {

components.add(getAndAdvance());

while (matches(TokenType.PERIOD)) {

advance();

- if (matches(TokenType.IDENTIFIER)) {

+ if (matchesIdentifier()) {

components.add(getAndAdvance());

} else {

reportError(ParserErrorCode.MISSING_IDENTIFIER);