Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Issue 25909002: Sampling profiler (Closed)

Created:
7 years, 2 months ago by Cutch
Modified:
7 years, 1 month ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Patch Set 15 : #

Patch Set 16 : #

Patch Set 17 : #

Patch Set 18 : #

Patch Set 19 : #

Patch Set 20 : #

Total comments: 66

Patch Set 21 : #

Patch Set 22 : #

Patch Set 23 : #

Patch Set 24 : #

Total comments: 39

Patch Set 25 : #

Patch Set 26 : #

Patch Set 27 : #

Patch Set 28 : #

Patch Set 29 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2332 lines, -47 lines) Patch
M runtime/bin/utils_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +11 lines, -1 line 0 comments Download
M runtime/bin/utils_macos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +11 lines, -1 line 0 comments Download
M runtime/platform/thread.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 3 chunks +56 lines, -0 lines 0 comments Download
M runtime/platform/thread_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/platform/thread_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 3 chunks +27 lines, -7 lines 0 comments Download
M runtime/platform/thread_linux.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/platform/thread_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 5 chunks +32 lines, -5 lines 0 comments Download
M runtime/platform/thread_macos.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/platform/thread_macos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 3 chunks +42 lines, -4 lines 0 comments Download
M runtime/platform/thread_win.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 5 chunks +12 lines, -1 line 0 comments Download
M runtime/platform/thread_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 8 chunks +95 lines, -7 lines 0 comments Download
M runtime/vm/dart.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 3 chunks +5 lines, -0 lines 0 comments Download
M runtime/vm/isolate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 5 chunks +20 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 7 chunks +36 lines, -0 lines 0 comments Download
A + runtime/vm/native_symbol.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +12 lines, -17 lines 0 comments Download
A runtime/vm/native_symbol_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 1 chunk +43 lines, -0 lines 0 comments Download
A runtime/vm/native_symbol_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 1 chunk +44 lines, -0 lines 0 comments Download
A runtime/vm/native_symbol_macos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 1 chunk +43 lines, -0 lines 0 comments Download
A runtime/vm/native_symbol_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +76 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 2 chunks +4 lines, -1 line 0 comments Download
M runtime/vm/object_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/os_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +7 lines, -0 lines 0 comments Download
A runtime/vm/profiler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +198 lines, -0 lines 0 comments Download
A runtime/vm/profiler.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 1 chunk +568 lines, -0 lines 0 comments Download
A runtime/vm/profiler_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 1 chunk +123 lines, -0 lines 0 comments Download
A runtime/vm/profiler_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +135 lines, -0 lines 0 comments Download
A runtime/vm/profiler_macos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +135 lines, -0 lines 0 comments Download
A runtime/vm/profiler_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +74 lines, -0 lines 0 comments Download
A runtime/vm/profiler_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 1 chunk +145 lines, -0 lines 0 comments Download
A runtime/vm/signal_handler.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +55 lines, -0 lines 0 comments Download
A runtime/vm/signal_handler_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 1 chunk +45 lines, -0 lines 0 comments Download
A runtime/vm/signal_handler_linux.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +94 lines, -0 lines 0 comments Download
A runtime/vm/signal_handler_macos.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +96 lines, -0 lines 0 comments Download
A runtime/vm/signal_handler_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +43 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_arm_test.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_ia32_test.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_mips_test.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_x64_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/unit_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/vm_sources.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 3 chunks +17 lines, -0 lines 0 comments Download
M tools/gyp/configurations_make.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +3 lines, -2 lines 0 comments Download
M tools/gyp/configurations_msvs.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Cutch
PTAL (windows work pending my return)
7 years, 2 months ago (2013-10-24 14:07:30 UTC) #1
siva
https://codereview.chromium.org/25909002/diff/64001/runtime/bin/utils_linux.cc File runtime/bin/utils_linux.cc (right): https://codereview.chromium.org/25909002/diff/64001/runtime/bin/utils_linux.cc#newcode105 runtime/bin/utils_linux.cc:105: int64_t delta = now - start; ASSERT(delta >= 0); ...
7 years, 1 month ago (2013-10-28 05:19:20 UTC) #2
Cutch
https://codereview.chromium.org/25909002/diff/64001/runtime/bin/utils_linux.cc File runtime/bin/utils_linux.cc (right): https://codereview.chromium.org/25909002/diff/64001/runtime/bin/utils_linux.cc#newcode105 runtime/bin/utils_linux.cc:105: int64_t delta = now - start; On 2013/10/28 05:19:21, ...
7 years, 1 month ago (2013-11-04 20:36:04 UTC) #3
siva
LGTM with some comments. https://codereview.chromium.org/25909002/diff/284001/runtime/platform/thread.h File runtime/platform/thread.h (right): https://codereview.chromium.org/25909002/diff/284001/runtime/platform/thread.h#newcode94 runtime/platform/thread.h:94: class ScopedMutexLock { Should we ...
7 years, 1 month ago (2013-11-11 03:51:53 UTC) #4
siva
Adding Zach to the cc list so he could look at the Android stuff.
7 years, 1 month ago (2013-11-11 21:41:23 UTC) #5
zra
On 2013/11/11 21:41:23, siva wrote: > Adding Zach to the cc list so he could ...
7 years, 1 month ago (2013-11-11 22:26:14 UTC) #6
zra
On 2013/11/11 22:26:14, zra wrote: > On 2013/11/11 21:41:23, siva wrote: > > Adding Zach ...
7 years, 1 month ago (2013-11-11 22:34:29 UTC) #7
siva
One question regarding dartium integration, will this work inside chrome? I remember there were some ...
7 years, 1 month ago (2013-11-12 16:01:55 UTC) #8
Cutch
https://codereview.chromium.org/25909002/diff/284001/runtime/platform/thread.h File runtime/platform/thread.h (right): https://codereview.chromium.org/25909002/diff/284001/runtime/platform/thread.h#newcode94 runtime/platform/thread.h:94: class ScopedMutexLock { On 2013/11/11 03:51:54, siva wrote: > ...
7 years, 1 month ago (2013-11-18 20:48:54 UTC) #9
Cutch
7 years, 1 month ago (2013-11-19 18:26:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #29 manually as r30419 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698