Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Unified Diff: runtime/vm/isolate.cc

Issue 25909002: Sampling profiler (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/native_symbol.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index 12711753744c0051f1e78013afb2584624dc1253..2bb694d7b9ff25689567c031dacdcda4ae938023 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -22,8 +22,10 @@
#include "vm/object_store.h"
#include "vm/parser.h"
#include "vm/port.h"
+#include "vm/profiler.h"
#include "vm/reusable_handles.h"
#include "vm/service.h"
+#include "vm/signal_handler.h"
#include "vm/simulator.h"
#include "vm/stack_frame.h"
#include "vm/stub_code.h"
@@ -309,6 +311,7 @@ Isolate::Isolate()
stack_frame_index_(-1),
object_histogram_(NULL),
object_id_ring_(NULL),
+ profiler_data_(NULL),
REUSABLE_HANDLE_LIST(REUSABLE_HANDLE_INITIALIZERS)
reusable_handles_() {
if (FLAG_print_object_histogram && (Dart::vm_isolate() != NULL)) {
@@ -337,7 +340,15 @@ Isolate::~Isolate() {
}
void Isolate::SetCurrent(Isolate* current) {
+ ScopedSignalBlocker ssb;
+ Isolate* old_isolate = Current();
+ if (old_isolate != NULL) {
+ ProfilerManager::DescheduleIsolate(old_isolate);
+ }
Thread::SetThreadLocal(isolate_key, reinterpret_cast<uword>(current));
+ if (current != NULL) {
+ ProfilerManager::ScheduleIsolate(current);
+ }
}
@@ -397,6 +408,10 @@ Isolate* Isolate::Init(const char* name_prefix) {
"\tisolate: %s\n", result->name());
}
}
+
+ // Setup for profiling.
+ ProfilerManager::SetupIsolateForProfiling(result);
+
return result;
}
@@ -444,6 +459,21 @@ void Isolate::SetStackLimit(uword limit) {
}
+bool Isolate::GetStackBounds(uintptr_t* lower, uintptr_t* upper) {
+ uintptr_t stack_lower = stack_limit();
+ if (stack_lower == static_cast<uintptr_t>(~0)) {
+ stack_lower = saved_stack_limit();
+ }
+ if (stack_lower == static_cast<uintptr_t>(~0)) {
+ return false;
+ }
+ uintptr_t stack_upper = stack_lower + GetSpecifiedStackSize();
+ *lower = stack_lower;
+ *upper = stack_upper;
+ return true;
+}
+
+
void Isolate::ScheduleInterrupts(uword interrupt_bits) {
// TODO(turnidge): Can't use MutexLocker here because MutexLocker is
// a StackResource, which requires a current isolate. Should
@@ -674,6 +704,11 @@ void Isolate::Shutdown() {
StackZone stack_zone(this);
HandleScope handle_scope(this);
+ ScopedSignalBlocker ssb;
+
+ ProfilerManager::DescheduleIsolate(this);
+
+
if (FLAG_print_object_histogram) {
heap()->CollectAllGarbage();
object_histogram()->Print();
@@ -715,6 +750,7 @@ void Isolate::Shutdown() {
// TODO(5411455): For now just make sure there are no current isolates
// as we are shutting down the isolate.
SetCurrent(NULL);
+ ProfilerManager::ShutdownIsolateForProfiling(this);
}
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/native_symbol.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698