Issue 25876002: test.py: Propagate the global --dartium option to the browser controller

Issue 25876002: test.py: Propagate the global --dartium option to the browser controller (Closed)

Created:
7 years, 2 months ago by kustermann

Modified:
7 years, 2 months ago

Reviewers:
ricow1, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

test.py: Propagate the global --dartium option to the browser controller R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=28222

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -33 lines)			Patch
M	tools/testing/dart/browser_controller.dart	View	1	9 chunks	+22 lines, -17 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	3 chunks	+4 lines, -14 lines	0 comments	Download
M	tools/testing/dart/utils.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/25876002/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/25876002/diff/1/tools/testing/dart/browser_controller.dart#newcode633 tools/testing/dart/browser_controller.dart:633: String local_ip; Would it be super painful to ...

7 years, 2 months ago (2013-10-03 14:14:18 UTC) #2

kustermann

https://codereview.chromium.org/25876002/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/25876002/diff/1/tools/testing/dart/browser_controller.dart#newcode633 tools/testing/dart/browser_controller.dart:633: String local_ip; On 2013/10/03 14:14:18, kasperl wrote: > Would ...

7 years, 2 months ago (2013-10-03 14:48:21 UTC) #3

kustermann

7 years, 2 months ago (2013-10-03 14:55:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r28222 (presubmit successful).

Expand Messages | Collapse Messages