tools/testing/dart/test_runner.dart - Issue 25876002: test.py: Propagate the global --dartium option to the browser controller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_runner.dart

Issue 25876002: test.py: Propagate the global --dartium option to the browser controller (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_runner.dart

diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart

index cb9de965995f306e38660440e7db8d2679ac0b84..92e09782d1c347e644e7f58e007a8463288aa9c3 100644

--- a/tools/testing/dart/test_runner.dart

+++ b/tools/testing/dart/test_runner.dart

@@ -2073,11 +2073,12 @@ class CommandExecutorImpl implements CommandExecutor {

}

Future<BrowserTestRunner> _getBrowserTestRunner(String browser) {

- var local_ip = globalConfiguration['local_ip'];

+ var localIp = globalConfiguration['local_ip'];

var num_browsers = maxBrowserProcesses;

if (_browserTestRunners[browser] == null) {

var testRunner =

- new BrowserTestRunner(local_ip, browser, num_browsers);

+ new BrowserTestRunner(

+ globalConfiguration, localIp, browser, num_browsers);

if (globalConfiguration['verbose']) {

testRunner.logger = DebugLogger.info;

}

« no previous file with comments | « tools/testing/dart/browser_controller.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »