Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 258733009: Rename blink -> _blink (Closed)

Created:
6 years, 8 months ago by Leaf
Modified:
6 years, 7 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Change name of blink_dartium.dart #

Patch Set 3 : Rebase changes #

Patch Set 4 : Changing the SDK back to original before regenerating #

Patch Set 5 : Regenerate SDK from dart repo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3823 lines, -11380 lines) Patch
A + sdk/lib/_blink/dartium/_blink_dartium.dart View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
D sdk/lib/blink/dartium/blink_dartium.dart View 1 2 3 1 chunk +0 lines, -7529 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 528 chunks +2581 lines, -2581 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 1 2 3 4 14 chunks +86 lines, -86 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 2 3 4 114 chunks +721 lines, -721 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 2 3 4 35 chunks +182 lines, -182 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 2 3 4 15 chunks +194 lines, -194 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 2 3 4 8 chunks +15 lines, -15 lines 0 comments Download
M tools/create_sdk.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/dartdomgenerator.py View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 2 3 3 chunks +3 lines, -15 lines 0 comments Download
M tools/dom/src/blink_native_DOMImplementation.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/html_native_DOMImplementation.dart View 1 2 3 6 chunks +24 lines, -24 lines 0 comments Download
A + tools/dom/templates/html/dartium/_blink_dartium.darttemplate View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
D tools/dom/templates/html/dartium/blink_dartium.darttemplate View 1 2 3 1 chunk +0 lines, -16 lines 0 comments Download
M tools/dom/templates/html/dartium/chrome_dartium.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/indexed_db_dartium.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/svg_dartium.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_audio_dartium.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_gl_dartium.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_sql_dartium.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Leaf
This renames blink to _blink.
6 years, 7 months ago (2014-04-28 20:21:01 UTC) #1
vsm
lgtm
6 years, 7 months ago (2014-04-28 20:53:42 UTC) #2
Leaf
6 years, 7 months ago (2014-04-28 21:56:37 UTC) #3
Message was sent while issue was closed. 
Committed patchset #5 manually as r35499 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698