Issue 25700006: Disable re-running of ContentShell commands on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25700006: Disable re-running of ContentShell commands on windows (Closed)

Created:
7 years, 2 months ago by kustermann

Modified:
7 years, 2 months ago

Reviewers:
ricow1, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Disable re-running of ContentShell commands on windows R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=28208

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	tools/testing/dart/test_runner.dart	View		1 chunk	+0 lines, -7 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/25700006/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (left): https://codereview.chromium.org/25700006/diff/1/tools/testing/dart/test_runner.dart#oldcode2176 tools/testing/dart/test_runner.dart:2176: } else if (command is ContentShellCommand) { Nice ...

7 years, 2 months ago (2013-10-03 11:14:22 UTC) #2

kustermann

7 years, 2 months ago (2013-10-03 11:22:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r28208 (presubmit successful).

Expand Messages | Collapse Messages