Make package mime strong clean

Make package mime strong clean

BUG=https://github.com/dart-lang/mime/issues/5
R=kevmoo@google.com

Committed: https://github.com/dart-lang/mime/commit/96c0d26d9ca3ca2604d6541118d7a2d572cbf24b

[keertip, 2016-12-09 02:21:58]

keertip@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2016-12-09 02:30:27]

https://codereview.chromium.org/2561953002/diff/1/test/mime_multipart_transfo...
File test/mime_multipart_transformer_test.dart (right):

https://codereview.chromium.org/2561953002/diff/1/test/mime_multipart_transfo...
test/mime_multipart_transformer_test.dart:28: StreamController<List<int>>
controller = new StreamController(sync: true);
make the left side var and add a generic to the right side.

https://codereview.chromium.org/2561953002/diff/1/test/mime_multipart_transfo...
test/mime_multipart_transformer_test.dart:94: StreamController<List<int>>
controller = new StreamController(sync: true);
ditto

https://codereview.chromium.org/2561953002/diff/1/test/mime_multipart_transfo...
test/mime_multipart_transformer_test.dart:120: StreamController<List<int>>
controller = new StreamController(sync: true);
ditto

https://codereview.chromium.org/2561953002/diff/1/test/mime_multipart_transfo...
test/mime_multipart_transformer_test.dart:144: Future.wait(futures).then((_) =>
completer.complete);
If you put a generic type on the completer does this get fixed? Instead of
creating another anonymous function

https://codereview.chromium.org/2561953002/diff/1/test/mime_type_test.dart
File test/mime_type_test.dart (right):

https://codereview.chromium.org/2561953002/diff/1/test/mime_type_test.dart#ne...
test/mime_type_test.dart:96: var actualMaxBytes = DEFAULT_MAGIC_NUMBERS.fold(0,
(num previous, magic) {
should be int, right?

[keertip, 2016-12-09 02:39:14]

https://codereview.chromium.org/2561953002/diff/1/test/mime_multipart_transfo...
File test/mime_multipart_transformer_test.dart (right):

https://codereview.chromium.org/2561953002/diff/1/test/mime_multipart_transfo...
test/mime_multipart_transformer_test.dart:28: StreamController<List<int>>
controller = new StreamController(sync: true);
On 2016/12/09 02:30:26, kevmoo wrote:
> make the left side var and add a generic to the right side.

Done.

https://codereview.chromium.org/2561953002/diff/1/test/mime_multipart_transfo...
test/mime_multipart_transformer_test.dart:94: StreamController<List<int>>
controller = new StreamController(sync: true);
On 2016/12/09 02:30:26, kevmoo wrote:
> ditto

Done.

https://codereview.chromium.org/2561953002/diff/1/test/mime_multipart_transfo...
test/mime_multipart_transformer_test.dart:120: StreamController<List<int>>
controller = new StreamController(sync: true);
On 2016/12/09 02:30:26, kevmoo wrote:
> ditto

Done.

https://codereview.chromium.org/2561953002/diff/1/test/mime_multipart_transfo...
test/mime_multipart_transformer_test.dart:144: Future.wait(futures).then((_) =>
completer.complete);
On 2016/12/09 02:30:26, kevmoo wrote:
> If you put a generic type on the completer does this get fixed? Instead of
> creating another anonymous function

That doesn't work. The original error is ERROR: The argument type '([dynamic]) →
void' can't be assigned to the parameter type '(List<dynamic>) → dynamic'.

[keertip, 2016-12-09 02:43:40]

https://codereview.chromium.org/2561953002/diff/1/test/mime_type_test.dart
File test/mime_type_test.dart (right):

https://codereview.chromium.org/2561953002/diff/1/test/mime_type_test.dart#ne...
test/mime_type_test.dart:96: var actualMaxBytes = DEFAULT_MAGIC_NUMBERS.fold(0,
(num previous, magic) {
On 2016/12/09 02:30:26, kevmoo wrote:
> should be int, right?

changed according to errror msg "Couldn't infer type parameter 'T'; 'dynamic'
must be of type 'num'. "

[kevmoo, 2016-12-09 02:53:32]

lgtm

https://codereview.chromium.org/2561953002/diff/1/test/mime_multipart_transfo...
File test/mime_multipart_transformer_test.dart (right):

https://codereview.chromium.org/2561953002/diff/1/test/mime_multipart_transfo...
test/mime_multipart_transformer_test.dart:144: Future.wait(futures).then((_) =>
completer.complete);
On 2016/12/09 02:39:14, keertip wrote:
> On 2016/12/09 02:30:26, kevmoo wrote:
> > If you put a generic type on the completer does this get fixed? Instead of
> > creating another anonymous function
> 
> That doesn't work. The original error is ERROR: The argument type '([dynamic])
→
> void' can't be assigned to the parameter type '(List<dynamic>) → dynamic'. 

So typing the completer as `var completer = new Completer<List>();` doesn't
work? Just want to confirm...

[keertip, 2016-12-09 19:27:10]

Description was changed from

==========
Make package mime strong clean

BUG=https://github.com/dart-lang/mime/issues/5
==========

to

==========
Make package mime strong clean

BUG=https://github.com/dart-lang/mime/issues/5
R=kevmoo@google.com

Committed:
https://github.com/dart-lang/mime/commit/96c0d26d9ca3ca2604d6541118d7a2d572cb...
==========

[keertip, 2016-12-09 19:27:12]

Committed patchset #3 (id:40001) manually as
96c0d26d9ca3ca2604d6541118d7a2d572cbf24b (presubmit successful).