Make package mime strong clean

test/mime_multipart_transformer_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:math';
 
 import "package:test/test.dart";
 import "package:mime/mime.dart";
 
 void _writeInChunks(
     List<int> data, int chunkSize, StreamController<List<int>> controller) {
   if (chunkSize == -1) chunkSize = data.length;
 
   for (int pos = 0; pos < data.length; pos += chunkSize) {
     int remaining = data.length - pos;
     int writeLength = min(chunkSize, remaining);
     controller.add(data.sublist(pos, pos + writeLength));
   }
   controller.close();
 }
 
 enum TestMode { IMMEDIATE_LISTEN, DELAY_LISTEN, PAUSE_RESUME }
 
 void _runParseTest(String message, String boundary, TestMode mode,
     [List<Map> expectedHeaders, List expectedParts, bool expectError = false]) {
   Future testWrite(List<int> data, [int chunkSize = -1]) {
-    StreamController controller = new StreamController(sync: true);
+    StreamController<List<int>> controller = new StreamController(sync: true);

[kevmoo, 2016/12/09 02:30:26]

make the left side var and add a generic to the right side.

[keertip, 2016/12/09 02:39:14]

Done.

 
     var stream =
         controller.stream.transform(new MimeMultipartTransformer(boundary));
     int i = 0;
     var completer = new Completer();
-    var futures = [];
+    var futures = <Future>[];
     stream.listen((multipart) {
       int part = i++;
       if (expectedHeaders != null) {
         expect(multipart.headers, equals(expectedHeaders[part]));
       }
       switch (mode) {
         case TestMode.IMMEDIATE_LISTEN:
           futures.add(multipart.fold([], (buffer, data) => buffer..addAll(data))
               .then((data) {
             if (expectedParts[part] != null) {
@@ skipping 29 matching lines @@
             completer.complete();
           });
           break;
       }
     }, onError: (error) {
       if (!expectError) throw error;
     }, onDone: () {
       if (expectedParts != null) {
         expect(i, equals(expectedParts.length));
       }
-      Future.wait(futures).then(completer.complete);
+      Future.wait(futures).then((_) => completer.complete);
     });
 
     _writeInChunks(data, chunkSize, controller);
 
     return completer.future;
   }
 
   Future testFirstPartOnly(List<int> data, [int chunkSize = -1]) {
     var completer = new Completer();
-    var controller = new StreamController(sync: true);
+    StreamController<List<int>> controller = new StreamController(sync: true);

[kevmoo, 2016/12/09 02:30:26]

ditto

[keertip, 2016/12/09 02:39:14]

Done.

 
     var stream =
         controller.stream.transform(new MimeMultipartTransformer(boundary));
 
     stream.first.then((multipart) {
       if (expectedHeaders != null) {
         expect(multipart.headers, equals(expectedHeaders[0]));
       }
       return (multipart.fold([], (b, d) => b..addAll(d)).then((data) {
         if (expectedParts != null && expectedParts[0] != null) {
           expect(data, equals(expectedParts[0].codeUnits));
         }
       }));
     }).then((_) {
       completer.complete();
     });
 
     _writeInChunks(data, chunkSize, controller);
 
     return completer.future;
   }
 
   Future testCompletePartAfterCancel(List<int> data, int parts,
       [int chunkSize = -1]) {
     var completer = new Completer();
-    var controller = new StreamController(sync: true);
+    StreamController<List<int>> controller = new StreamController(sync: true);

[kevmoo, 2016/12/09 02:30:26]

ditto

[keertip, 2016/12/09 02:39:14]

Done.

     var stream =
         controller.stream.transform(new MimeMultipartTransformer(boundary));
     var subscription;
     int i = 0;
-    var futures = [];
+    var futures = <Future>[];
     subscription = stream.listen((multipart) {
       int partIndex = i;
 
       if (partIndex >= parts) {
         throw 'Expected no more parts, but got one.';
       }
 
       if (expectedHeaders != null) {
         expect(multipart.headers, equals(expectedHeaders[partIndex]));
       }
       futures.add((multipart.fold([], (b, d) => b..addAll(d)).then((data) {
         if (expectedParts != null && expectedParts[partIndex] != null) {
           expect(data, equals(expectedParts[partIndex].codeUnits));
         }
       })));
 
       if (partIndex == (parts - 1)) {
         subscription.cancel();
-        Future.wait(futures).then(completer.complete);
+        Future.wait(futures).then((_) => completer.complete);

[kevmoo, 2016/12/09 02:30:26]

If you put a generic type on the completer does this get fixed? Instead of
creating another anonymous function

[keertip, 2016/12/09 02:39:14]

That doesn't work. The original error is ERROR: The argument type '([dynamic]) →
void' can't be assigned to the parameter type '(List<dynamic>) → dynamic'. 

[kevmoo, 2016/12/09 02:53:32]

So typing the completer as `var completer = new Completer<List>();` doesn't
work? Just want to confirm...

       }
       i++;
     });
 
     _writeInChunks(data, chunkSize, controller);
 
     return completer.future;
   }
 
   // Test parsing the data three times delivering the data in
@@ skipping 289 matching lines @@
 \r
 Body2\r
 --xxx\r\n""";
   _testParse(message, "xxx", null, [null, null], true);
 }
 
 void main() {
   _testParseValid();
   _testParseInvalid();
 }