Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 25600002: Rework redirection_type_shuffling_test to not require status override for analyzer. (Closed)

Created:
7 years, 2 months ago by rmacnak
Modified:
7 years, 2 months ago
Reviewers:
regis, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rework redirection_type_shuffling_test to not require status override for analyzer. R=brianwilkerson@google.com, regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=28116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M tests/lib/lib.status View 2 chunks +1 line, -4 lines 0 comments Download
M tests/lib/mirrors/redirection_type_shuffling_test.dart View 1 chunk +18 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
7 years, 2 months ago (2013-10-01 20:39:36 UTC) #1
Brian Wilkerson
LGTM!
7 years, 2 months ago (2013-10-01 20:44:57 UTC) #2
regis
LGTM
7 years, 2 months ago (2013-10-01 20:47:48 UTC) #3
rmacnak
7 years, 2 months ago (2013-10-01 20:48:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r28116 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698