Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: tests/lib/mirrors/redirection_type_shuffling_test.dart

Issue 25600002: Rework redirection_type_shuffling_test to not require status override for analyzer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/lib.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/redirection_type_shuffling_test.dart
diff --git a/tests/lib/mirrors/redirection_type_shuffling_test.dart b/tests/lib/mirrors/redirection_type_shuffling_test.dart
index 6b25da089548ca021eb78d191347f16a5f6c3455..582b4148202554c6b6c4a6917ac87fd56ad9b867 100644
--- a/tests/lib/mirrors/redirection_type_shuffling_test.dart
+++ b/tests/lib/mirrors/redirection_type_shuffling_test.dart
@@ -7,14 +7,30 @@ import "package:expect/expect.dart";
class G<A extends int, B extends String> {
G();
- factory G.swap() = G<B,A>;
+ factory G.swap() = G<B,A>; /// static type warning
factory G.retain() = G<A,B>;
}
+bool get inCheckedMode {
+ try {
+ var i = 1;
+ String s = i;
+ return false;
+ } catch(e) {
+ return true;
+ }
+}
+
main() {
ClassMirror cm = reflect(new G<int, String>()).type;
- cm.newInstance(#swap, []); /// 01: dynamic type error
+ if (inCheckedMode) {
+ Expect.throws(() => cm.newInstance(#swap, []),
+ (e) => e is MirroredCompilationError,
+ 'Checked mode should not allow violation of type bounds');
+ } else {
+ Expect.isTrue(cm.newInstance(#swap, []).reflectee is G<String,int>);
+ }
Expect.isTrue(cm.newInstance(#retain, []).reflectee is G<int,String>);
}
« no previous file with comments | « tests/lib/lib.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698