Issue 25478009: Handle compile-time constness for conditionals and type literal calls.

Issue 25478009: Handle compile-time constness for conditionals and type literal calls. (Closed)

Created:
7 years, 2 months ago by Johnni Winther

Modified:
7 years, 2 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle compile-time constness for conditionals and type literal calls. BUG=http://dartbug.com/13270 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=28154

Patch Set 3 : Updated cf. comments #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -17 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compile_time_constants.dart	View	1 2	6 chunks	+33 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2	2 chunks	+6 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download
A	tests/language/const_conditional_test.dart	View		1 chunk	+56 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

DBC https://codereview.chromium.org/25478009/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart (right): https://codereview.chromium.org/25478009/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart#newcode570 sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:570: return signalNotCompileTimeConstant(node); IF condition is not bool, we ...

7 years, 2 months ago (2013-10-02 10:44:43 UTC) #2

karlklose

LGTM. https://codereview.chromium.org/25478009/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart (right): https://codereview.chromium.org/25478009/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart#newcode405 sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:405: compiler.backend.registerTypeLiteral( Move this registration. https://codereview.chromium.org/25478009/diff/1/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): ...

7 years, 2 months ago (2013-10-02 11:08:55 UTC) #3

Johnni Winther

https://codereview.chromium.org/25478009/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart File sdk/lib/_internal/compiler/implementation/compile_time_constants.dart (right): https://codereview.chromium.org/25478009/diff/1/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart#newcode405 sdk/lib/_internal/compiler/implementation/compile_time_constants.dart:405: compiler.backend.registerTypeLiteral( On 2013/10/02 11:08:55, karlklose wrote: > Move this ...

7 years, 2 months ago (2013-10-02 12:39:33 UTC) #4

Johnni Winther

7 years, 2 months ago (2013-10-02 12:48:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r28154 (presubmit successful).

Expand Messages | Collapse Messages