sdk/lib/_internal/compiler/implementation/resolution/members.dart - Issue 25478009: Handle compile-time constness for conditionals and type literal calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 25478009: Handle compile-time constness for conditionals and type literal calls. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart

diff --git a/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/sdk/lib/_internal/compiler/implementation/resolution/members.dart

index 10680e7c2ec6dae3cba62a4b36c20e652414a225..7a27b1d398e436ca27dc88b2d924da81808c55bf 100644

--- a/sdk/lib/_internal/compiler/implementation/resolution/members.dart

+++ b/sdk/lib/_internal/compiler/implementation/resolution/members.dart

@@ -2441,7 +2441,9 @@ class ResolverVisitor extends MappingVisitor<Element> {

// type literal.

mapping.setType(node, compiler.typeClass.computeType(compiler));

world.registerTypeLiteral(target, mapping);

- analyzeConstant(node);

+ // Don't try to make constants of calls to type literals.

+ analyzeConstant(node, isConst: !node.isCall);

}

@@ -2892,11 +2894,10 @@ class ResolverVisitor extends MappingVisitor<Element> {

return null;

}

- void analyzeConstant(Node node) {

+ void analyzeConstant(Node node, {bool isConst: true}) {

addPostProcessAction(enclosingElement, () {

- mapping.setConstant(node,

- compiler.constantHandler.compileNodeWithDefinitions(

- node, mapping, isConst: true));

+ compiler.constantHandler.compileNodeWithDefinitions(

+ node, mapping, isConst: isConst);

});

}