Issue 254683003: Fix stacktrace crasher bug in the VM and duplicate breakpoint crasher bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 254683003: Fix stacktrace crasher bug in the VM and duplicate breakpoint crasher bug. (Closed)

Created:
6 years, 8 months ago by Jacob

Modified:
6 years, 8 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Workaround stacktrace crasher bug in the VM. Fix for bug setting breakpoint after app reload. BUG= R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=35401

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	runtime/lib/stacktrace.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download
	M	runtime/vm/debugger.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jacob

https://codereview.chromium.org/254683003/diff/1/runtime/lib/stacktrace.cc File runtime/lib/stacktrace.cc (right): https://codereview.chromium.org/254683003/diff/1/runtime/lib/stacktrace.cc#newcode30 runtime/lib/stacktrace.cc:30: return String::New(trace.ToCStringInternal(&frame_index)); needed to avoid a null ptr exception.

6 years, 8 months ago (2014-04-24 20:28:55 UTC) #1

Jacob

6 years, 8 months ago (2014-04-24 20:34:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35401 (presubmit successful).

Expand Messages | Collapse Messages