runtime/lib/stacktrace.cc - Issue 254683003: Fix stacktrace crasher bug in the VM and duplicate breakpoint crasher bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/stacktrace.cc

Issue 254683003: Fix stacktrace crasher bug in the VM and duplicate breakpoint crasher bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/stacktrace.cc

diff --git a/runtime/lib/stacktrace.cc b/runtime/lib/stacktrace.cc

index 486d96d32c5423d25191aaecbf305ccd84528bf2..3e02ca997d1a2174fe926b782a009079d3866189 100644

--- a/runtime/lib/stacktrace.cc

+++ b/runtime/lib/stacktrace.cc

@@ -26,7 +26,8 @@ DEFINE_NATIVE_ENTRY(Stacktrace_getFullStacktrace, 1) {

DEFINE_NATIVE_ENTRY(Stacktrace_getStacktrace, 1) {

const Stacktrace& trace =

Stacktrace::CheckedHandle(arguments->NativeArgAt(0));

- return String::New(trace.ToCStringInternal(0));

+ intptr_t frame_index = 0;

+ return String::New(trace.ToCStringInternal(&frame_index));

Jacob 2014/04/24 20:28:55 needed to avoid a null ptr exception.

}

« no previous file with comments | « no previous file | runtime/vm/debugger.cc » ('j') | no next file with comments »