Issue 254673007: More stubs and instructions for arm64.

Issue 254673007: More stubs and instructions for arm64. (Closed)

Created:
6 years, 8 months ago by zra

Modified:
6 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More stubs and instructions for arm64. Also, more tests enabled. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35554

Patch Set 2 : hello, simarm64 #

Patch Set 6 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1288 lines, -64 lines)			Patch
M	runtime/vm/assembler_arm64.h	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View	1 2 3 4	1 chunk	+51 lines, -0 lines	0 comments	Download
M	runtime/vm/cha_test.cc	View	1 2 3	2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/compiler_test.cc	View	1 2 3	2 chunks	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 2 3	10 chunks	+953 lines, -45 lines	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View	1 2 3	4 chunks	+20 lines, -4 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1 2 3 4 5	3 chunks	+258 lines, -3 lines	0 comments	Download
M	runtime/vm/unit_test.cc	View	1 2 3	2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

Again, this is all mostly copied from ARM with small fix-ups. With this change "Hello, ...

6 years, 7 months ago (2014-04-29 22:56:07 UTC) #1

regis

LGTM Getting there... https://codereview.chromium.org/254673007/diff/70001/runtime/vm/stub_code_arm64.cc File runtime/vm/stub_code_arm64.cc (right): https://codereview.chromium.org/254673007/diff/70001/runtime/vm/stub_code_arm64.cc#newcode469 runtime/vm/stub_code_arm64.cc:469: __ csel(R1, TMP2, R1, HI); Can't ...

6 years, 7 months ago (2014-04-29 23:09:21 UTC) #2

zra

Thanks! https://codereview.chromium.org/254673007/diff/70001/runtime/vm/stub_code_arm64.cc File runtime/vm/stub_code_arm64.cc (right): https://codereview.chromium.org/254673007/diff/70001/runtime/vm/stub_code_arm64.cc#newcode469 runtime/vm/stub_code_arm64.cc:469: __ csel(R1, TMP2, R1, HI); On 2014/04/29 23:09:21, ...

6 years, 7 months ago (2014-04-29 23:18:18 UTC) #3

zra

6 years, 7 months ago (2014-04-29 23:18:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #6 manually as r35554 (presubmit successful).

Expand Messages | Collapse Messages