Issue 25373002: Issue 13584. Fix for Java/Dart local variable scoping mismatch.

Issue 25373002: Issue 13584. Fix for Java/Dart local variable scoping mismatch. (Closed)

Created:
7 years, 2 months ago by scheglov

Modified:
7 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 13584. Fix for Java/Dart local variable scoping mismatch. https://code.google.com/p/dart/issues/detail?id=13574 We now use "this" (or type name for static) qualifier for any member reference that is shadowed by local variable or parameter. This fixes specified issue and also another one, which was quick-patched during M7 push. Also generated code is a little better. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=28078

Patch Set 1 #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1494 lines, -1120 lines)			Patch
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java	View	11 chunks	+86 lines, -215 lines	2 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/BeautifySemanticProcessor.java	View	2 chunks	+5 lines, -0 lines	0 comments	Download
A	editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/LocalVariablesSemanticProcessor.java	View	1 chunk	+292 lines, -0 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java	View	4 chunks	+314 lines, -210 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/BeautifySemanticProcessorTest.java	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/TypeSemanticProcessorTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/ast.dart	View	79 chunks	+163 lines, -163 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/constant.dart	View	15 chunks	+64 lines, -64 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/element.dart	View	78 chunks	+206 lines, -205 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/engine.dart	View	21 chunks	+39 lines, -39 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/error.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/html.dart	View	5 chunks	+11 lines, -11 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/instrumentation.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/parser.dart	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/resolver.dart	View	51 chunks	+127 lines, -108 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/scanner.dart	View	5 chunks	+20 lines, -20 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/src/generated/sdk.dart	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	pkg/analyzer_experimental/test/generated/ast_test.dart	View	12 chunks	+16 lines, -16 lines	0 comments	Download
M	pkg/analyzer_experimental/test/generated/element_test.dart	View	11 chunks	+29 lines, -29 lines	0 comments	Download
M	pkg/analyzer_experimental/test/generated/resolver_test.dart	View	12 chunks	+96 lines, -9 lines	0 comments	Download
M	pkg/analyzer_experimental/test/generated/scanner_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer_experimental/test/generated/test_support.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/co19/co19-analyzer2.status	View	2 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/25373002/diff/1/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java File editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java (right): https://codereview.chromium.org/25373002/diff/1/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java#newcode221 editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java:221: public void ensureMethodParameterDoesNotHide(CompilationUnit unit) { Do we need ...

7 years, 2 months ago (2013-10-01 00:34:55 UTC) #2

scheglov

Committed patchset #1 manually as r28078 (presubmit successful).

7 years, 2 months ago (2013-10-01 01:18:29 UTC) #3

scheglov

7 years, 2 months ago (2013-10-01 01:18:51 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/25373002/diff/1/editor/util/plugins/com.googl...
File
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java
(right):

https://codereview.chromium.org/25373002/diff/1/editor/util/plugins/com.googl...
editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java:221:
public void ensureMethodParameterDoesNotHide(CompilationUnit unit) {
On 2013/10/01 00:34:55, Brian Wilkerson wrote:
> Do we need to keep this method?

Done.

Expand Messages | Collapse Messages