editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java - Issue 25373002: Issue 13584. Fix for Java/Dart local variable scoping mismatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java

Issue 25373002: Issue 13584. Fix for Java/Dart local variable scoping mismatch. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java ('K') | « editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java ('k') | editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/BeautifySemanticProcessor.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java

diff --git a/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java b/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java

index 4ed06eedcb9f5c3fb10dd72e131325374314e2e4..7e852c79eb1ffe7a7e6ac66239d949eb776f5c23 100644

--- a/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java

+++ b/editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java

@@ -222,7 +222,7 @@ public class MainEngine {

}

// run this again, because we may introduce conflicts when convert methods to getters/setters

context.ensureUniqueClassMemberNames(dartUnit);

- context.ensureNoVariableNameReferenceFromInitializer(dartUnit);

+ context.applyLocalVariableSemanticChanges(dartUnit);

context.ensureMethodParameterDoesNotHide(dartUnit);

// handle reflection

EngineSemanticProcessor.rewriteReflectionFieldsWithDirect(context, dartUnit);