Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 253023004: Add MapMixin to dart:collection. (Closed)

Created:
6 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 7 months ago
CC:
reviews_dartlang.org, Johnni Winther
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M sdk/lib/collection/maps.dart View 1 chunk +19 lines, -2 lines 3 comments Download
M tests/corelib/map_test.dart View 7 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Lasse Reichstein Nielsen
Alternative: Make MapBase be usable as a mixin (just entails removing the constructor that was ...
6 years, 7 months ago (2014-04-29 11:31:10 UTC) #1
kevmoo
DBC Take a look at the new lines in the doc comments. To have a ...
6 years, 7 months ago (2014-04-29 13:41:11 UTC) #2
Lasse Reichstein Nielsen
I believe the line breaks are exactly where I want them :). I try to ...
6 years, 7 months ago (2014-04-29 13:52:27 UTC) #3
Lasse Reichstein Nielsen
Ping Anders.
6 years, 7 months ago (2014-05-07 10:57:26 UTC) #4
Anders Johnsen
lgtm
6 years, 7 months ago (2014-05-07 10:58:32 UTC) #5
floitsch
LGTM. sorry. forgot again.
6 years, 7 months ago (2014-05-07 11:06:48 UTC) #6
Johnni Winther
I think we need https://codereview.chromium.org/267153002/ to be committed before this CL.
6 years, 7 months ago (2014-05-07 11:21:28 UTC) #7
Lasse Reichstein Nielsen
6 years, 7 months ago (2014-05-08 11:36:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r35904 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698