Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 25276003: Don't emit errors from the socket when we are closing it down. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen
Modified:
7 years, 2 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Don't emit errors from the socket when we are closing it down. The socket may be deleted at this point, so getting the error can be 'use-after-free'. Also, the actual error doesn't help, as the user can't do anything about a bad close (note that all data is 'flushed' before close is called). BUG=https://code.google.com/p/dart/issues/detail?id=12982 R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=28053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M runtime/bin/socket_patch.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 2 months ago (2013-09-30 14:55:10 UTC) #1
Bill Hesse
LGTM :)
7 years, 2 months ago (2013-09-30 14:56:03 UTC) #2
Anders Johnsen
7 years, 2 months ago (2013-09-30 14:57:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28053 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698