runtime/bin/socket_patch.dart - Issue 25276003: Don't emit errors from the socket when we are closing it down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket_patch.dart

Issue 25276003: Don't emit errors from the socket when we are closing it down. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/socket_patch.dart

diff --git a/runtime/bin/socket_patch.dart b/runtime/bin/socket_patch.dart

index 7a4694b428eac52728a8574d64ca94200653e81c..4fffbf7681da5b896221836d310aa03aa98cb514 100644

--- a/runtime/bin/socket_patch.dart

+++ b/runtime/bin/socket_patch.dart

@@ -484,7 +484,9 @@ class _NativeSocket extends NativeFieldWrapperClass1 {

continue;

}

if (i == ERROR_EVENT) {

- reportError(nativeGetError(), "");

+ if (!isClosing) {

+ reportError(nativeGetError(), "");

+ }

} else if (!isClosed) {

// If the connection is closed right after it's accepted, there's a

// chance the close-handler is not set.

« no previous file with comments | « no previous file | tests/standalone/standalone.status » ('j') | no next file with comments »