Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 25173003: Give better error messages for users when trying to run the 64 bit editor on a 32 bit JVM (Closed)

Created:
7 years, 2 months ago by ricow1
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Give better error messages for users when trying to run the 64 bit editor on a 32 bit JVM This basically changes a huge stack trace on stdout to: Error: This Java instance does not support a 64-bit JVM. Please install the desired version. R=danrubel@google.com, devoncarew@google.com Committed: https://code.google.com/p/dart/source/detail?r=28512

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M editor/build/build.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/create_editor.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
Devon/Dan: Dan suggested the other day that we have no better way of setting these ...
7 years, 2 months ago (2013-09-30 09:06:56 UTC) #1
danrubel
lgtm
7 years, 2 months ago (2013-09-30 11:27:12 UTC) #2
devoncarew
lgtm
7 years, 2 months ago (2013-10-07 18:48:59 UTC) #3
ricow1
7 years, 2 months ago (2013-10-11 12:19:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r28512 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698