Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2951)

Unified Diff: editor/build/build.py

Issue 25173003: Give better error messages for users when trying to run the 64 bit editor on a 32 bit JVM (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/create_editor.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/build/build.py
===================================================================
--- editor/build/build.py (revision 28043)
+++ editor/build/build.py (working copy)
@@ -914,6 +914,8 @@
f.close()
lines[lines.index('-Xms40m\n')] = '-Xms256m\n'
lines[lines.index('-Xmx1000m\n')] = '-Xmx2000m\n'
+ # Add -d64 to give better error messages to user in 64 bit mode.
+ lines[lines.index('-vmargs\n')] = '-vmargs\n-d64\n'
f = open(iniFilePath, 'w')
f.writelines(lines);
f.close()
« no previous file with comments | « no previous file | tools/create_editor.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698