Issue 25138003: Cache the context proxy. Don't use window for global 'this'.

Issue 25138003: Cache the context proxy. Don't use window for global 'this'. (Closed)

Created:
7 years, 2 months ago by justinfagnani

Modified:
7 years, 2 months ago

Reviewers:
vsm, alexandre.ardhuin, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cache the context proxy. Don't use window for global 'this'. BUG= R=ahe@google.com, alexandre.ardhuin@gmail.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=28181

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -12 lines)			Patch
M	pkg/browser/lib/interop.js	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/isolate_helper.dart	View	1 2	2 chunks	+1 line, -3 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_helper.dart	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/js/dart2js/js_dart2js.dart	View	1 2	1 chunk	+2 lines, -4 lines	0 comments	Download
M	sdk/lib/js/dartium/js_dartium.dart	View		1 chunk	+10 lines, -4 lines	0 comments	Download
M	tests/html/js_test.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/25138003/diff/1/sdk/lib/js/dart2js/js_dart2js.dart File sdk/lib/js/dart2js/js_dart2js.dart (right): https://codereview.chromium.org/25138003/diff/1/sdk/lib/js/dart2js/js_dart2js.dart#newcode10 sdk/lib/js/dart2js/js_dart2js.dart:10: JsObject _context; Can't you just do: final JsObject ...

7 years, 2 months ago (2013-09-28 00:55:09 UTC) #2

justinfagnani

https://codereview.chromium.org/25138003/diff/1/sdk/lib/js/dart2js/js_dart2js.dart File sdk/lib/js/dart2js/js_dart2js.dart (right): https://codereview.chromium.org/25138003/diff/1/sdk/lib/js/dart2js/js_dart2js.dart#newcode10 sdk/lib/js/dart2js/js_dart2js.dart:10: JsObject _context; On 2013/09/28 00:55:09, vsm wrote: > Can't ...

7 years, 2 months ago (2013-09-28 01:02:15 UTC) #3

ahe

LGTM! https://codereview.chromium.org/25138003/diff/5001/sdk/lib/_internal/lib/js_helper.dart File sdk/lib/_internal/lib/js_helper.dart (right): https://codereview.chromium.org/25138003/diff/5001/sdk/lib/_internal/lib/js_helper.dart#newcode70 sdk/lib/_internal/lib/js_helper.dart:70: computeGlobalThis() => JS('', 'function() { return this; }()'); ...

7 years, 2 months ago (2013-10-02 10:19:55 UTC) #5

justinfagnani

https://codereview.chromium.org/25138003/diff/5001/sdk/lib/_internal/lib/js_helper.dart File sdk/lib/_internal/lib/js_helper.dart (right): https://codereview.chromium.org/25138003/diff/5001/sdk/lib/_internal/lib/js_helper.dart#newcode70 sdk/lib/_internal/lib/js_helper.dart:70: computeGlobalThis() => JS('', 'function() { return this; }()'); On ...

7 years, 2 months ago (2013-10-02 20:38:21 UTC) #6

justinfagnani

7 years, 2 months ago (2013-10-02 21:07:07 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 manually as r28181 (presubmit successful).

Expand Messages | Collapse Messages