Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 251043003: Observatory Display PC descriptors with disassembling (Closed)

Created:
6 years, 7 months ago by Cutch
Modified:
6 years, 7 months ago
Reviewers:
turnidge, srdjan
CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org
Visibility:
Public.

Description

Display PC descriptors with disassembling in Observatory Couple other fixes: - Fix path to shared css - Fix crash when printing null AbstractType. R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=35529

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3160 lines, -2583 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 4 chunks +95 lines, -7 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 1 2 364 chunks +1237 lines, -1243 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 4 chunks +95 lines, -7 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 364 chunks +1237 lines, -1243 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/breakpoint_list.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/class_ref.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/class_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/code_ref.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/code_view.html View 1 2 2 chunks +96 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/error_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/field_ref.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/field_view.html View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/function_ref.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/function_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/heap_map.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/heap_profile.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_ref.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/instance_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_profile.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_ref.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_summary.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/isolate_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/library_ref.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/library_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/nav_bar.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/script_ref.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/service_error_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/service_exception_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/stack_frame.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/stack_trace.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/vm_ref.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/vm_view.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
A runtime/bin/vmservice/client/dotdot.sh View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/breakpoint_list.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/class_ref.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/class_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/code_ref.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/code_view.dart View 2 chunks +32 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/code_view.html View 1 2 chunks +96 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/error_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/field_ref.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/field_view.html View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/function_ref.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/function_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/heap_map.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/heap_profile.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/instance_ref.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/instance_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_profile.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_ref.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/library_ref.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/library_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/nav_bar.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/script_ref.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_error_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_exception_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/stack_frame.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/stack_trace.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/vm_ref.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/vm_view.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/object.dart View 1 8 chunks +166 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/client/notdotdot.sh View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/pubspec.yaml View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/native_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 3 chunks +36 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cutch
6 years, 7 months ago (2014-04-28 15:02:56 UTC) #1
turnidge
lgtm https://codereview.chromium.org/251043003/diff/1/runtime/bin/vmservice/client/lib/src/service/object.dart File runtime/bin/vmservice/client/lib/src/service/object.dart (right): https://codereview.chromium.org/251043003/diff/1/runtime/bin/vmservice/client/lib/src/service/object.dart#newcode1005 runtime/bin/vmservice/client/lib/src/service/object.dart:1005: @observable PcDescriptor descriptor; from offline: support multiple descriptors.
6 years, 7 months ago (2014-04-28 17:41:49 UTC) #2
Cutch
https://codereview.chromium.org/251043003/diff/1/runtime/bin/vmservice/client/lib/src/service/object.dart File runtime/bin/vmservice/client/lib/src/service/object.dart (right): https://codereview.chromium.org/251043003/diff/1/runtime/bin/vmservice/client/lib/src/service/object.dart#newcode1005 runtime/bin/vmservice/client/lib/src/service/object.dart:1005: @observable PcDescriptor descriptor; On 2014/04/28 17:41:49, turnidge wrote: > ...
6 years, 7 months ago (2014-04-28 22:48:00 UTC) #3
Cutch
6 years, 7 months ago (2014-04-29 16:41:14 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r35529 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698