Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/code_view.dart

Issue 251043003: Observatory Display PC descriptors with disassembling (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/code_view.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/code_view.dart b/runtime/bin/vmservice/client/lib/src/elements/code_view.dart
index dacbab88ffbcbd0094db6dbe15b601f4eef5db22..b42e63e6211469a18ee4b47fcbcd266ade1304ee 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/code_view.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/code_view.dart
@@ -4,6 +4,7 @@
library code_view_element;
+import 'dart:html';
import 'observatory_element.dart';
import 'package:observatory/service.dart';
import 'package:polymer/polymer.dart';
@@ -18,14 +19,41 @@ class CodeViewElement extends ObservatoryElement {
if (code == null) {
return;
}
- code.load();
+ code.load().then((Code c) {
+ c.loadScript();
+ });
}
void refresh(var done) {
code.reload().whenComplete(done);
}
- String get cssPanelClass {
- return 'panel panel-success';
+ Element _findJumpTarget(Node target) {
+ var jumpTarget = target.attributes['data-jump-target'];
+ if (jumpTarget == '') {
+ return null;
+ }
+ var address = int.parse(jumpTarget);
+ var node = shadowRoot.querySelector('#addr-$address');
+ if (node == null) {
+ return null;
+ }
+ return node;
+ }
+
+ void mouseOver(Event e, var detail, Node target) {
+ var jt = _findJumpTarget(target);
+ if (jt == null) {
+ return;
+ }
+ jt.classes.add('highlight');
+ }
+
+ void mouseOut(Event e, var detail, Node target) {
+ var jt = _findJumpTarget(target);
+ if (jt == null) {
+ return;
+ }
+ jt.classes.remove('highlight');
}
-}
+}

Powered by Google App Engine
This is Rietveld 408576698