Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 25046002: Emit a compile-time error when a named optional parameter has a library private name. (Closed)

Created:
7 years, 2 months ago by karlklose
Modified:
7 years, 2 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Emit a compile-time error when a named optional parameter has a library private name. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=28012

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 5 chunks +19 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
7 years, 2 months ago (2013-09-27 13:34:01 UTC) #1
Johnni Winther
lgtm
7 years, 2 months ago (2013-09-27 13:50:54 UTC) #2
karlklose
7 years, 2 months ago (2013-09-27 14:34:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28012 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698