Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/warnings.dart

Issue 25046002: Emit a compile-time error when a named optional parameter has a library private name. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 const DONT_KNOW_HOW_TO_FIX = ""; 7 const DONT_KNOW_HOW_TO_FIX = "";
8 8
9 /** 9 /**
10 * The messages in this file should meet the following guide lines: 10 * The messages in this file should meet the following guide lines:
(...skipping 915 matching lines...) Expand 10 before | Expand all | Expand 10 after
926 Hint: Using "new #{name}' may result in larger output. 926 Hint: Using "new #{name}' may result in larger output.
927 Use 'const #{name}' if possible.'''); 927 Use 'const #{name}' if possible.''');
928 928
929 static const MessageKind STRING_EXPECTED = const MessageKind( 929 static const MessageKind STRING_EXPECTED = const MessageKind(
930 "Error: Expected a 'String', but got an instance of '#{type}'."); 930 "Error: Expected a 'String', but got an instance of '#{type}'.");
931 931
932 static const MessageKind PRIVATE_IDENTIFIER = const MessageKind( 932 static const MessageKind PRIVATE_IDENTIFIER = const MessageKind(
933 "Error: '#{value}' is not a valid Symbol name because it starts with " 933 "Error: '#{value}' is not a valid Symbol name because it starts with "
934 "'_'."); 934 "'_'.");
935 935
936 static const MessageKind PRIVATE_NAMED_PARAMETER = const MessageKind(
937 "Error: Named optional parameter can't have a library private name.",
938 howToFix: "Try removing the '_' or making the parameter positional or "
939 "required.",
940 examples: const ["""foo({int _p}) {} main() => foo();"""]
941 );
942
936 static const MessageKind UNSUPPORTED_LITERAL_SYMBOL = const MessageKind( 943 static const MessageKind UNSUPPORTED_LITERAL_SYMBOL = const MessageKind(
937 "Internal Error: Symbol literal '##{value}' is currently unsupported."); 944 "Internal Error: Symbol literal '##{value}' is currently unsupported.");
938 945
939 static const MessageKind INVALID_SYMBOL = const MessageKind(''' 946 static const MessageKind INVALID_SYMBOL = const MessageKind('''
940 Error: '#{value}' is not a valid Symbol name because is not: 947 Error: '#{value}' is not a valid Symbol name because is not:
941 * an empty String, 948 * an empty String,
942 * a user defined operator, 949 * a user defined operator,
943 * a qualified non-private identifier optionally followed by '=', or 950 * a qualified non-private identifier optionally followed by '=', or
944 * a qualified non-private identifier followed by '.' and a user-defined ''' 951 * a qualified non-private identifier followed by '.' and a user-defined '''
945 "operator."); 952 "operator.");
(...skipping 416 matching lines...) Expand 10 before | Expand all | Expand 10 after
1362 1369
1363 class CompileTimeConstantError extends Diagnostic { 1370 class CompileTimeConstantError extends Diagnostic {
1364 CompileTimeConstantError(MessageKind kind, Map arguments, bool terse) 1371 CompileTimeConstantError(MessageKind kind, Map arguments, bool terse)
1365 : super(kind, arguments, terse); 1372 : super(kind, arguments, terse);
1366 } 1373 }
1367 1374
1368 class CompilationError extends Diagnostic { 1375 class CompilationError extends Diagnostic {
1369 CompilationError(MessageKind kind, Map arguments, bool terse) 1376 CompilationError(MessageKind kind, Map arguments, bool terse)
1370 : super(kind, arguments, terse); 1377 : super(kind, arguments, terse);
1371 } 1378 }
OLDNEW
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/resolution/members.dart ('k') | tests/co19/co19-dart2dart.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698