Issue 24984003: Make reflectClass in dart2js behave appropriately when passed bad arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24984003: Make reflectClass in dart2js behave appropriately when passed bad arguments (Closed)

Created:
7 years, 2 months ago by rmacnak

Modified:
7 years, 2 months ago

Reviewers:
ahe, zarah

CC:
reviews_dartlang.org, Michael Lippautz (Google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Make reflectClass in dart2js behave appropriately when passed bad arguments. BUG=http://dartbug.com/13145 R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=28269

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
	M	sdk/lib/_internal/lib/mirrors_patch.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	A	tests/lib/mirrors/reflect_class_test.dart	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

rmacnak

Picking up https://codereview.chromium.org/24042004/ from Michael.

7 years, 2 months ago (2013-09-27 17:17:00 UTC) #1

rmacnak

7 years, 2 months ago (2013-10-04 17:25:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r28269 (presubmit successful).