Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 247863005: Revert "Insert checks before deferred calls and accesses." (Closed)

Created:
6 years, 8 months ago by sigurdm
Modified:
6 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Insert checks before deferred calls and accesses." This reverts commit r35306. Committed: https://code.google.com/p/dart/source/detail?r=35308

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -262 lines) Patch
M sdk/lib/_internal/compiler/implementation/compile_time_constants.dart View 1 chunk +24 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/deferred_load.dart View 6 chunks +3 lines, -76 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 2 chunks +0 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 5 chunks +1 line, -7 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 2 chunks +0 lines, -10 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 6 chunks +3 lines, -25 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/ssa.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/lib/js_helper.dart View 7 chunks +8 lines, -25 lines 0 comments Download
M tests/compiler/dart2js_extra/deferred/deferred_class_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js_extra/deferred/deferred_function_test.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M tests/language/deferred_constraints_type_annotation_old_syntax_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/language/deferred_not_loaded_check_lib.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/language/deferred_not_loaded_check_test.dart View 1 chunk +0 lines, -72 lines 0 comments Download
M tests/language/language.status View 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sigurdm
tbr
6 years, 8 months ago (2014-04-23 09:22:32 UTC) #1
sigurdm
Committed patchset #1 manually as r35308 (presubmit successful).
6 years, 8 months ago (2014-04-23 09:23:51 UTC) #2
Johnni Winther
6 years, 8 months ago (2014-04-23 10:19:13 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698