Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: tests/compiler/dart2js_extra/deferred/deferred_function_test.dart

Issue 247863005: Revert "Insert checks before deferred calls and accesses." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // Test that loading of a library (with top-level functions only) can 5 // Test that loading of a library (with top-level functions only) can
6 // be deferred. 6 // be deferred.
7 7
8 import 'package:async_helper/async_helper.dart'; 8 import 'package:async_helper/async_helper.dart';
9 import 'package:expect/expect.dart'; 9 import 'package:expect/expect.dart';
10 10
11 import 'dart:async'; 11 import 'dart:async';
12 12
13 @lazy import 'deferred_function_library.dart' as lib; 13 @lazy import 'deferred_function_library.dart' as lib;
14 14
15 const lazy = const DeferredLibrary('deferred_function_library'); 15 const lazy = const DeferredLibrary('deferred_function_library');
16 16
17 isError(e) => e is Error; 17 isNoSuchMethodError(e) => e is NoSuchMethodError;
18 18
19 readFoo() { 19 readFoo() {
20 // TODO(ahe): There is a problem with type inference of deferred
21 // function closures. We think they are never null.
22 if (new DateTime.now().millisecondsSinceEpoch == 87) return null;
20 return lib.foo; 23 return lib.foo;
21 } 24 }
22 25
23 main() { 26 main() {
24 Expect.throws(() { lib.foo('a'); }, isError); 27 Expect.throws(() { lib.foo('a'); }, isNoSuchMethodError);
25 Expect.throws(readFoo, isError); 28 Expect.throws(readFoo, isNoSuchMethodError);
26 int counter = 0; 29 int counter = 0;
27 asyncStart(); 30 asyncStart();
28 lazy.load().then((_) { 31 lazy.load().then((_) {
29 Expect.equals(1, ++counter); 32 Expect.equals(1, ++counter);
30 print('lazy was loaded'); 33 print('lazy was loaded');
31 Expect.equals(42, lib.foo('b')); 34 Expect.equals(42, lib.foo('b'));
32 Expect.isNotNull(readFoo()); 35 Expect.isNotNull(readFoo());
33 asyncEnd(); 36 asyncEnd();
34 }); 37 });
35 Expect.equals(0, counter); 38 Expect.equals(0, counter);
36 asyncStart(); 39 asyncStart();
37 lazy.load().then((_) { 40 lazy.load().then((_) {
38 Expect.equals(2, ++counter); 41 Expect.equals(2, ++counter);
39 print('lazy was loaded'); 42 print('lazy was loaded');
40 Expect.equals(42, lib.foo('b')); 43 Expect.equals(42, lib.foo('b'));
41 Expect.isNotNull(readFoo()); 44 Expect.isNotNull(readFoo());
42 asyncEnd(); 45 asyncEnd();
43 }); 46 });
44 Expect.equals(0, counter); 47 Expect.equals(0, counter);
45 Expect.throws(() { lib.foo('a'); }, isError); 48 Expect.throws(() { lib.foo('a'); }, isNoSuchMethodError);
46 Expect.throws(readFoo, isError); 49 Expect.throws(readFoo, isNoSuchMethodError);
47 } 50 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698