Issue 247683002: Reapply "Mark private functions in dart:* that are native or constructors as not visible (omitted f…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 247683002: Reapply "Mark private functions in dart:* that are native or constructors as not visible (omitted f… (Closed)

Created:
6 years, 8 months ago by rmacnak

Modified:
6 years, 8 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Mark private functions in dart:* that are native or constructors as not visible (omitted from stack traces and ineligible for reflective enumeration or invocation)." With fix for uninitialized is_dart_scheme_ when read from snapshot. BUG=http://dartbug.com/15274 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=35289

Patch Set 1 #

Patch Set 2 : update snapshot read/write #

Patch Set 3 : regen snapshot test #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -216 lines)			Patch
M	runtime/lib/mirrors.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View		2 chunks	+3 lines, -38 lines	0 comments	Download
M	runtime/vm/object_test.cc	View		1 chunk	+9 lines, -10 lines	0 comments	Download
M	runtime/vm/parser.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View		4 chunks	+18 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tests/lib/lib.status	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
A +	tests/lib/mirrors/invocation_fuzz_test.dart	View		6 chunks	+55 lines, -28 lines	0 comments	Download
D	tests/lib/mirrors/invoke_natives_fuzz_test.dart	View		1 chunk	+0 lines, -135 lines	0 comments	Download
M	tests/standalone/issue14236_test.dart	View	1 2	Binary file		0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rmacnak

Fix bug where language/error_stacktrace_test vm/dart/error_stacktrace_test pkg/stack_trace/test/chain_test would fail sometimes to due Library::is_dart_scheme_ not being initialized ...

6 years, 8 months ago (2014-04-22 22:42:34 UTC) #1

rmacnak

6 years, 8 months ago (2014-04-23 00:05:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r35289 (presubmit successful).

Expand Messages | Collapse Messages