Reapply "Mark private functions in dart:* that are native or constructors as not visible (omitted f…

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 138 matching lines @@
     reinterpret_cast<RawClass*>(RAW_NULL);
 RawClass* Object::unwind_error_class_ = reinterpret_cast<RawClass*>(RAW_NULL);
 
 
 const double MegamorphicCache::kLoadFactor = 0.75;
 
 
 // The following functions are marked as invisible, meaning they will be hidden
 // in the stack trace and will be hidden from reflective access.
 // (Library, class name, method name)
+// Additionally, private functions in dart:* that are native or constructors are
+// marked as invisible by the parser.
 #define INVISIBLE_LIST(V)                                                      \
-  V(CoreLibrary, Object, _noSuchMethod)                                        \
-  V(CoreLibrary, Object, _as)                                                  \
-  V(CoreLibrary, Object, _instanceOf)                                          \
-  V(CoreLibrary, _List, _List.)                                                \
-  V(CoreLibrary, AssertionError, _throwNew)                                    \
-  V(CoreLibrary, TypeError, _throwNew)                                         \
-  V(CoreLibrary, FallThroughError, _throwNew)                                  \
-  V(CoreLibrary, AbstractClassInstantiationError, _throwNew)                   \
   V(CoreLibrary, int, _throwFormatException)                                   \
   V(CoreLibrary, int, _parse)                                                  \
-  V(CoreLibrary, StackTrace, _setupFullStackTrace)                             \
-  V(CoreLibrary, _OneByteString, _setAt)                                       \
-  V(CoreLibrary, _StringBase, _substringUncheckedNative)                       \
-  V(CoreLibrary, _OneByteString, _substringUncheckedNative)                    \
-  V(CoreLibrary, _GrowableList, _setData)                                      \
-  V(CoreLibrary, _GrowableList, _setLength)                                    \
-  V(TypedDataLibrary, _TypedList, _getInt8)                                    \
-  V(TypedDataLibrary, _TypedList, _setInt8)                                    \
-  V(TypedDataLibrary, _TypedList, _getUint8)                                   \
-  V(TypedDataLibrary, _TypedList, _setUint8)                                   \
-  V(TypedDataLibrary, _TypedList, _getInt16)                                   \
-  V(TypedDataLibrary, _TypedList, _setInt16)                                   \
-  V(TypedDataLibrary, _TypedList, _getUint16)                                  \
-  V(TypedDataLibrary, _TypedList, _setUint16)                                  \
-  V(TypedDataLibrary, _TypedList, _getInt32)                                   \
-  V(TypedDataLibrary, _TypedList, _setInt32)                                   \
-  V(TypedDataLibrary, _TypedList, _getUint32)                                  \
-  V(TypedDataLibrary, _TypedList, _setUint32)                                  \
-  V(TypedDataLibrary, _TypedList, _getInt64)                                   \
-  V(TypedDataLibrary, _TypedList, _setInt64)                                   \
-  V(TypedDataLibrary, _TypedList, _getUint64)                                  \
-  V(TypedDataLibrary, _TypedList, _setUint64)                                  \
-  V(TypedDataLibrary, _TypedList, _getFloat32)                                 \
-  V(TypedDataLibrary, _TypedList, _setFloat32)                                 \
-  V(TypedDataLibrary, _TypedList, _getFloat64)                                 \
-  V(TypedDataLibrary, _TypedList, _setFloat64)                                 \
-  V(TypedDataLibrary, _TypedList, _getFloat32x4)                               \
-  V(TypedDataLibrary, _TypedList, _setFloat32x4)                               \
-
-
 
 static void MarkFunctionAsInvisible(const Library& lib,
                                     const char* class_name,
                                     const char* function_name) {
   ASSERT(!lib.IsNull());
   const Class& cls = Class::Handle(
       lib.LookupClassAllowPrivate(String::Handle(String::New(class_name))));
   ASSERT(!cls.IsNull());
   const Function& function =
       Function::Handle(
@@ skipping 8746 matching lines @@
                       GrowableObjectArray::New(4, Heap::kOld));
   result.raw_ptr()->anonymous_classes_ = Object::empty_array().raw();
   result.raw_ptr()->num_anonymous_ = 0;
   result.raw_ptr()->imports_ = Object::empty_array().raw();
   result.raw_ptr()->exports_ = Object::empty_array().raw();
   result.raw_ptr()->loaded_scripts_ = Array::null();
   result.set_native_entry_resolver(NULL);
   result.set_native_entry_symbol_resolver(NULL);
   result.raw_ptr()->corelib_imported_ = true;
   result.set_debuggable(false);
+  result.set_is_dart_scheme(url.StartsWith(Symbols::DartScheme()));
   result.raw_ptr()->load_state_ = RawLibrary::kAllocated;
   result.raw_ptr()->index_ = -1;
   const intptr_t kInitialNameCacheSize = 64;
   result.InitResolvedNamesCache(kInitialNameCacheSize);
   result.InitClassDictionary();
   result.InitImportList();
   result.AllocatePrivateKey();
   if (import_core_lib) {
     const Library& core_lib = Library::Handle(Library::CoreLibrary());
     ASSERT(!core_lib.IsNull());
@@ skipping 9486 matching lines @@
   return tag_label.ToCString();
 }
 
 
 void UserTag::PrintToJSONStream(JSONStream* stream, bool ref) const {
   Instance::PrintToJSONStream(stream, ref);
 }
 
 
 }  // namespace dart