Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 24748003: Fix bug in the requested type of an SSA instruction: avoid requesting a ContainerTypeMask. (Closed)

Created:
7 years, 2 months ago by ngeoffray
Modified:
7 years, 2 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug in the requested type of an SSA instruction: avoid requesting a ContainerTypeMask. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart View 1 chunk +4 lines, -1 line 0 comments Download
A tests/language/bailout_container_type_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 2 months ago (2013-09-26 12:50:16 UTC) #1
kasperl
LGTM!
7 years, 2 months ago (2013-09-26 12:52:49 UTC) #2
ngeoffray
7 years, 2 months ago (2013-09-26 13:02:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27949 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698