Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart

Issue 24748003: Fix bug in the requested type of an SSA instruction: avoid requesting a ContainerTypeMask. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/bailout_container_type_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart (revision 27940)
+++ sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart (working copy)
@@ -397,7 +397,10 @@
HType computeDesiredTypeForInput(HInstruction user, HInstruction input) {
this.input = input;
- HType desired = user.accept(this);
+ // We simplify the desired type to avoid requesting the type of an
+ // instantiation node, for example [ContainerTypeMask].
+ HType desired = user.accept(this).simplify(compiler);
+ assert(!desired.computeMask(compiler).isContainer);
this.input = null;
return desired;
}
« no previous file with comments | « no previous file | tests/language/bailout_container_type_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698