Automatically append ".js" on spawnUri if we are running in JavaScript.

Automatically append ".js" on spawnUri if we are running in JavaScript.

BUG= http://dartbug.com/9422
R=kasperl@google.com, kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27941

[kasperl, 2013-09-26 09:28:44]

LGTM.

[kustermann, 2013-09-26 09:34:33]

I like it :-)

LGTM with comments.

https://codereview.chromium.org/24730002/diff/3001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/24730002/diff/3001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1050: String baseName =
namePath.filenameWithoutExtension;
I'd change this to
String filename = namePath.filename;

https://codereview.chromium.org/24730002/diff/3001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1055: fromPath.toNativePath(),
'$tempDir/$baseName.dart.js',
Then you can do change this to
fromPath.toNativePath(), '$tempDir/$filename.js',

https://codereview.chromium.org/24730002/diff/3001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1063: new
File('$tempDir/$baseName.dart').writeAsStringSync(result);
And this to
new File('$tempDir/$filename').writeAsStringSync(result);

[floitsch, 2013-09-26 10:56:15]

Thanks.

https://codereview.chromium.org/24730002/diff/3001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/24730002/diff/3001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1050: String baseName =
namePath.filenameWithoutExtension;
On 2013/09/26 09:34:34, kustermann wrote:
> I'd change this to
> String filename = namePath.filename;

Done.

https://codereview.chromium.org/24730002/diff/3001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1055: fromPath.toNativePath(),
'$tempDir/$baseName.dart.js',
On 2013/09/26 09:34:34, kustermann wrote:
> Then you can do change this to
> fromPath.toNativePath(), '$tempDir/$filename.js',

Done.

https://codereview.chromium.org/24730002/diff/3001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1063: new
File('$tempDir/$baseName.dart').writeAsStringSync(result);
On 2013/09/26 09:34:34, kustermann wrote:
> And this to
> new File('$tempDir/$filename').writeAsStringSync(result);

Done.

[floitsch, 2013-09-26 11:32:26]

Committed patchset #4 manually as r27941 (presubmit successful).