Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 24730002: Automatically append ".js" on spawnUri if we are running in JavaScript. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix typo. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/isolate/spawn_uri_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 7908ae37ceab17e62ea6c1ee7e53e021116f5663..e98f6f1386b3cf1938fe5cc5a4efd5510d807768 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1070,12 +1070,12 @@ class StandardTestSuite extends TestSuite {
List<String> otherScripts = optionsFromFile['otherScripts'];
for (String name in otherScripts) {
Path namePath = new Path(name);
- String baseName = namePath.filenameWithoutExtension;
+ String fileName = namePath.filename;
Path fromPath = filePath.directoryPath.join(namePath);
if (compiler != 'none') {
assert(namePath.extension == 'dart');
commands.add(_compileCommand(
- fromPath.toNativePath(), '$tempDir/$baseName.js',
+ fromPath.toNativePath(), '$tempDir/$fileName.js',
compiler, tempDir, vmOptions, optionsFromFile));
}
if (compiler == 'none') {
@@ -1083,7 +1083,7 @@ class StandardTestSuite extends TestSuite {
// compiled, move the input scripts over with the script so they can
// be accessed.
String result = new File(fromPath.toNativePath()).readAsStringSync();
- new File('$tempDir/$baseName.dart').writeAsStringSync(result);
+ new File('$tempDir/$fileName').writeAsStringSync(result);
}
}
« no previous file with comments | « tests/isolate/spawn_uri_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698