Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 247223009: Reduce test.dart memory usage (Closed)

Created:
6 years, 8 months ago by Bill Hesse
Modified:
6 years, 8 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Reduce test.dart memory usage BUG=dartbug.com/18084 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=35365

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address comments #

Patch Set 3 : Clear static pointer to closure when finished #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -67 lines) Patch
M tools/testing/dart/test_progress.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 10 chunks +74 lines, -51 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 2 6 chunks +6 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
https://codereview.chromium.org/247223009/diff/1/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (left): https://codereview.chromium.org/247223009/diff/1/tools/testing/dart/test_progress.dart#oldcode84 tools/testing/dart/test_progress.dart:84: && !test.expectCompileError) { This is the one case who's ...
6 years, 8 months ago (2014-04-23 17:38:44 UTC) #1
ricow1
lgtm https://codereview.chromium.org/247223009/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/247223009/diff/1/tools/testing/dart/test_runner.dart#newcode725 tools/testing/dart/test_runner.dart:725: static final int IS_NEGATIVE = 1 << 0; ...
6 years, 8 months ago (2014-04-23 17:49:36 UTC) #2
Bill Hesse
6 years, 8 months ago (2014-04-24 11:10:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r35365 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698