Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Unified Diff: tools/testing/dart/test_progress.dart

Issue 247223009: Reduce test.dart memory usage (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Clear static pointer to closure when finished Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_progress.dart
diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart
index 6bfa8283abd772d82e166cf0631576b8ab6dac09..e315c3465c42ed5ffef3ff0193e0fefbac5148c9 100644
--- a/tools/testing/dart/test_progress.dart
+++ b/tools/testing/dart/test_progress.dart
@@ -79,7 +79,7 @@ List<String> _buildFailureOutput(TestCase test,
}
output.add(expected.toString());
output.add('Actual: ${test.result}');
- if (!test.lastCommandOutput.hasTimedOut && test.info != null) {
+ if (!test.lastCommandOutput.hasTimedOut) {
if (test.commandOutputs.length != test.commands.length
&& !test.expectCompileError) {
output.add('Unexpected compile-time error.');
@@ -87,10 +87,10 @@ List<String> _buildFailureOutput(TestCase test,
if (test.expectCompileError) {
output.add('Compile-time error expected.');
}
- if (test.info.hasRuntimeError) {
+ if (test.hasRuntimeError) {
output.add('Runtime error expected.');
}
- if (test.configuration['checked'] && test.info.isNegativeIfChecked) {
+ if (test.configuration['checked'] && test.isNegativeIfChecked) {
output.add('Dynamic type error expected.');
}
}
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698