Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24698003: Removed the openglui sample app. (Closed)

Created:
7 years, 2 months ago by shailentuli
Modified:
7 years, 2 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Removed the openglui sample app. R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=27925

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13762 lines) Patch
M dart.gyp View 1 chunk +1 line, -3 lines 1 comment Download
D samples/openglui/.gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
D samples/openglui/android-blasteroids/AndroidManifest.xml View 1 chunk +0 lines, -32 lines 0 comments Download
D samples/openglui/android-blasteroids/android.gyp View 1 chunk +0 lines, -166 lines 0 comments Download
D samples/openglui/android-blasteroids/build.xml View 1 chunk +0 lines, -96 lines 0 comments Download
D samples/openglui/android-blasteroids/custom_rules.xml View 1 chunk +0 lines, -16 lines 0 comments Download
D samples/openglui/android-blasteroids/project.properties View 1 chunk +0 lines, -21 lines 0 comments Download
D samples/openglui/android-blasteroids/res/drawable-hdpi/ic_launcher.png View Binary file 0 comments Download
D samples/openglui/android-blasteroids/res/drawable-ldpi/ic_launcher.png View Binary file 0 comments Download
D samples/openglui/android-blasteroids/res/drawable-mdpi/ic_launcher.png View Binary file 0 comments Download
D samples/openglui/android-blasteroids/res/drawable-xhdpi/ic_launcher.png View Binary file 0 comments Download
D samples/openglui/android-blasteroids/res/values/strings.xml View 1 chunk +0 lines, -8 lines 0 comments Download
D samples/openglui/android-blasteroids/res/values/styles.xml View 1 chunk +0 lines, -20 lines 0 comments Download
D samples/openglui/android-blasteroids/src/com/google/dartndk/DummyActivity.java View 1 chunk +0 lines, -42 lines 0 comments Download
D samples/openglui/android-canvas-tests/AndroidManifest.xml View 1 chunk +0 lines, -32 lines 0 comments Download
D samples/openglui/android-canvas-tests/android.gyp View 1 chunk +0 lines, -72 lines 0 comments Download
D samples/openglui/android-canvas-tests/assets/chrome.png View Binary file 0 comments Download
D samples/openglui/android-canvas-tests/build.xml View 1 chunk +0 lines, -96 lines 0 comments Download
D samples/openglui/android-canvas-tests/custom_rules.xml View 1 chunk +0 lines, -16 lines 0 comments Download
D samples/openglui/android-canvas-tests/project.properties View 1 chunk +0 lines, -21 lines 0 comments Download
D samples/openglui/android-canvas-tests/res/values/strings.xml View 1 chunk +0 lines, -8 lines 0 comments Download
D samples/openglui/android-canvas-tests/res/values/styles.xml View 1 chunk +0 lines, -20 lines 0 comments Download
D samples/openglui/android-canvas-tests/src/com/google/dartndk/DummyActivity.java View 1 chunk +0 lines, -42 lines 0 comments Download
D samples/openglui/android-webgl-raytrace/AndroidManifest.xml View 1 chunk +0 lines, -32 lines 0 comments Download
D samples/openglui/android-webgl-raytrace/android.gyp View 1 chunk +0 lines, -72 lines 0 comments Download
D samples/openglui/android-webgl-raytrace/build.xml View 1 chunk +0 lines, -96 lines 0 comments Download
D samples/openglui/android-webgl-raytrace/custom_rules.xml View 1 chunk +0 lines, -16 lines 0 comments Download
D samples/openglui/android-webgl-raytrace/project.properties View 1 chunk +0 lines, -21 lines 0 comments Download
D samples/openglui/android-webgl-raytrace/res/drawable-hdpi/ic_launcher.png View Binary file 0 comments Download
D samples/openglui/android-webgl-raytrace/res/drawable-ldpi/ic_launcher.png View Binary file 0 comments Download
D samples/openglui/android-webgl-raytrace/res/drawable-mdpi/ic_launcher.png View Binary file 0 comments Download
D samples/openglui/android-webgl-raytrace/res/drawable-xhdpi/ic_launcher.png View Binary file 0 comments Download
D samples/openglui/android-webgl-raytrace/res/values/strings.xml View 1 chunk +0 lines, -8 lines 0 comments Download
D samples/openglui/android-webgl-raytrace/res/values/styles.xml View 1 chunk +0 lines, -20 lines 0 comments Download
D samples/openglui/android-webgl-raytrace/src/com/google/dartndk/DummyActivity.java View 1 chunk +0 lines, -42 lines 0 comments Download
D samples/openglui/emulator/emulator.gyp View 1 chunk +0 lines, -120 lines 0 comments Download
D samples/openglui/emulator/mobile_emulator_sample.cc View 1 chunk +0 lines, -10 lines 0 comments Download
D samples/openglui/openglui.gyp View 1 chunk +0 lines, -37 lines 0 comments Download
D samples/openglui/pubspec.yaml View 1 chunk +0 lines, -5 lines 0 comments Download
D samples/openglui/src/blasteroids.dart View 1 chunk +0 lines, -3334 lines 0 comments Download
D samples/openglui/src/chrome.hex View 1 chunk +0 lines, -7444 lines 0 comments Download
D samples/openglui/src/flashingbox.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D samples/openglui/src/gl.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D samples/openglui/src/openglui_canvas_tests.dart View 1 chunk +0 lines, -1047 lines 0 comments Download
D samples/openglui/src/openglui_raytrace.dart View 1 chunk +0 lines, -364 lines 0 comments Download
D samples/openglui/web/blasteroids.css View 1 chunk +0 lines, -17 lines 0 comments Download
D samples/openglui/web/blasteroids.html View 1 chunk +0 lines, -21 lines 0 comments Download
D samples/openglui/web/blasteroids_driver.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D samples/openglui/web/canvas_tests.html View 1 chunk +0 lines, -20 lines 0 comments Download
D samples/openglui/web/flashingbox.html View 1 chunk +0 lines, -17 lines 0 comments Download
D samples/openglui/web/flashingbox_driver.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D samples/openglui/web/gl_driver.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D samples/openglui/web/openglui_canvas_tests_driver.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D samples/openglui/web/openglui_raytrace_driver.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D samples/openglui/web/raytrace.html View 1 chunk +0 lines, -20 lines 0 comments Download
D samples/openglui/web/simplegl.css View 1 chunk +0 lines, -17 lines 0 comments Download
D samples/openglui/web/simplegl.html View 1 chunk +0 lines, -19 lines 0 comments Download
D samples/openglui/web/web.gyp View 1 chunk +0 lines, -89 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
shailentuli
PTAL. Not removing runtime/embedders/openglui/. Other mentions of openglui are not under version control: dart.xcodeproj/project.pbxproj xcodebuild/openglui/
7 years, 2 months ago (2013-09-25 23:57:19 UTC) #1
vsm
lgtm https://codereview.chromium.org/24698003/diff/1/dart.gyp File dart.gyp (right): https://codereview.chromium.org/24698003/diff/1/dart.gyp#newcode201 dart.gyp:201: 'dependencies': [], I think you can delete this ...
7 years, 2 months ago (2013-09-26 00:01:02 UTC) #2
shailentuli
7 years, 2 months ago (2013-09-26 00:19:43 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r27925 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698