Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 246733004: Don't use fatal errors in message_kind_test.dart. (Closed)

Created:
6 years, 8 months ago by ahe
Modified:
6 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't use fatal errors in message_kind_test.dart. BUG=http://dartbug.com/18363 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=35422

Patch Set 1 #

Patch Set 2 : Merged with r35420 (this included restoring exceptions for fatal errors, due to parser tests) #

Patch Set 3 : Restore white lists, safe reuse. #

Total comments: 6

Patch Set 4 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -22 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/resolution/signatures.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js/memory_compiler.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M dart/tests/compiler/dart2js/message_kind_helper.dart View 1 2 3 6 chunks +13 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ahe
6 years, 8 months ago (2014-04-22 14:50:20 UTC) #1
Johnni Winther
lgtm
6 years, 8 months ago (2014-04-23 07:22:30 UTC) #2
ahe
PTAL, updated per our discussion.
6 years, 8 months ago (2014-04-25 09:41:21 UTC) #3
Johnni Winther
lgtm https://codereview.chromium.org/246733004/diff/40001/dart/tests/compiler/dart2js/message_kind_helper.dart File dart/tests/compiler/dart2js/message_kind_helper.dart (right): https://codereview.chromium.org/246733004/diff/40001/dart/tests/compiler/dart2js/message_kind_helper.dart#newcode23 dart/tests/compiler/dart2js/message_kind_helper.dart:23: // See http://dartbug.com/18361. Replace . by : to ...
6 years, 8 months ago (2014-04-25 09:57:55 UTC) #4
ahe
Thank you, Johnni! https://codereview.chromium.org/246733004/diff/40001/dart/tests/compiler/dart2js/message_kind_helper.dart File dart/tests/compiler/dart2js/message_kind_helper.dart (right): https://codereview.chromium.org/246733004/diff/40001/dart/tests/compiler/dart2js/message_kind_helper.dart#newcode23 dart/tests/compiler/dart2js/message_kind_helper.dart:23: // See http://dartbug.com/18361. On 2014/04/25 09:57:55, ...
6 years, 8 months ago (2014-04-25 12:51:16 UTC) #5
ahe
6 years, 8 months ago (2014-04-25 12:53:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r35422 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698